Merged
Conversation
- adds type safe bindings / triggers - decreases api surface considerably - loops replaced with concurrent executions
1. unsafeBind(id,handler,interface{}),
2. globalBind(typedPayload)
3. bind(typedCaller,typedPayload)
This migrates all packages but examples, entities, and joystickviz
- adjusts the loading scene to not use a loop. - keyboard-viz example working
This still needs work on every non-windows driver, as well as adjustment in window.Window to only include those things all default drivers have.
scene: Embed Eventhandler to allow for some embedded calls
Doc + refactor pass 1 for oak v4
writer_js is being removed because it is not functional yet.
README: Update the readme to have a few more points added
Feature/v4 examples
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
+ Coverage 92.27% 94.98% +2.71%
==========================================
Files 141 143 +2
Lines 6456 6344 -112
==========================================
+ Hits 5957 6026 +69
+ Misses 438 287 -151
+ Partials 61 31 -30
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Implausiblyfun
approved these changes
May 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.