bugfix - ignore subsets of near-zero-ratio#187
Merged
zhiltsov-max merged 5 commits intodevelopfrom Mar 26, 2021
Merged
Conversation
jihyeonyi
commented
Mar 26, 2021
Author
jihyeonyi
left a comment
jihyeonyi
left a comment
There was a problem hiding this comment.
Thank you for the modification.
It looks better.
zhiltsov-max
pushed a commit
that referenced
this pull request
Mar 31, 2021
* bugfix - ignore subsets of near-zero-ratio (#187) * Ignore subsets of near-zero-ratio in splitter Co-authored-by: Maxim Zhiltsov <maxim.zhiltsov@intel.com> * Fix validator imbalance threshold (#190) * Validator threshold adjustment + style correction Co-authored-by: Maxim Zhiltsov <maxim.zhiltsov@intel.com> * Allow undeclared label attributes on CVAT format (#192) * Add saving and parsing of attributes in label categories in Datumaro format * Support common label attributes in CVAT format, add an option to ignore undeclared attributes * Add logging for parsed parameters in plugins * update changelog * Fix export of masks with holes (#188) * Fix export of masks with holes in polygons (background class should not introduce a new instance) * update changelog * Format fixes in COCO and VOC (#195) * Allow splitting and merging of image directories in COCO export * Avoid producing conflicting attributes in VOC segmentation Co-authored-by: Jihyeon Yi <jihyeon.yi@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When dataset size is 5 and split ratio is [train=0.1, val=0.9, test=0.0], the splitter splits the dataset into [1, 3, 1] instead of [1, 4, 0].
This is a special case of incorrect partitioning due to the inexact round function of python.
So I fix this bug by ignoring subsets with a near-zero ratio.
How to test
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.