Skip to content

Kate/validator imbalance thr#190

Merged
zhiltsov-max merged 2 commits intodevelopfrom
kate/validator-imbalance-thr
Mar 30, 2021
Merged

Kate/validator imbalance thr#190
zhiltsov-max merged 2 commits intodevelopfrom
kate/validator-imbalance-thr

Conversation

@jihyeonyi
Copy link
Copy Markdown

Summary

  1. I've found wrong threshold values are used in the validator, so I've corrected them.
  2. Style correction for following PEP8

How to test

python -m unittest -v tests/test_validator.py

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@jihyeonyi jihyeonyi force-pushed the kate/validator-imbalance-thr branch from 2d9c954 to b8d43b3 Compare March 29, 2021 10:21
self.ann_type = ann_type

self.far_from_mean_thr = far_from_mean_thr
self.imbalance_ratio_thr = self.DEFAULT_IMBALANCE_RATIO
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider putting this into the ClassificationValidator, if this is not supposed to be used anywhere else.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is commonly used by ClassificationValidator and DetectionValidator. So I think this is the right place.

@zhiltsov-max zhiltsov-max merged commit d51e746 into develop Mar 30, 2021
zhiltsov-max pushed a commit that referenced this pull request Mar 31, 2021
* bugfix - ignore subsets of near-zero-ratio (#187)

* Ignore subsets of near-zero-ratio in splitter

Co-authored-by: Maxim Zhiltsov <maxim.zhiltsov@intel.com>

* Fix validator imbalance threshold (#190)

* Validator threshold adjustment + style correction

Co-authored-by: Maxim Zhiltsov <maxim.zhiltsov@intel.com>

* Allow undeclared label attributes on CVAT format (#192)

* Add saving and parsing of attributes in label categories in Datumaro format

* Support common label attributes in CVAT format, add an option to ignore undeclared attributes

* Add logging for parsed parameters in plugins

* update changelog

* Fix export of masks with holes (#188)

* Fix export of masks with holes in polygons (background class should not introduce a new instance)

* update changelog

* Format fixes in COCO and VOC (#195)

* Allow splitting and merging of image directories in COCO export

* Avoid producing conflicting attributes in VOC segmentation

Co-authored-by: Jihyeon Yi <jihyeon.yi@intel.com>
@zhiltsov-max zhiltsov-max deleted the kate/validator-imbalance-thr branch April 20, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants