Feature/12 information page#45
Closed
robinmolen wants to merge 12 commits intofeature/12-formlayout-test-setupfrom
Closed
Feature/12 information page#45robinmolen wants to merge 12 commits intofeature/12-formlayout-test-setupfrom
robinmolen wants to merge 12 commits intofeature/12-formlayout-test-setupfrom
Conversation
6 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/12-formlayout-test-setup #45 +/- ##
====================================================================
+ Coverage 78.92% 84.28% +5.35%
====================================================================
Files 35 39 +4
Lines 261 299 +38
Branches 43 53 +10
====================================================================
+ Hits 206 252 +46
+ Misses 49 40 -9
- Partials 6 7 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…lled-radio Formik controlled RadioField component
…st-setup Feature/12 formlayout test setup
…lled-checkbox Formik controlled checkbox
6 tasks
We require access to the v2 and v3 api endpoints. To make this easily doable `/v3` or `/v2` shouldn't be part of the BASE_URL.
Added readonly as a textfield property, which adds the accessible 'readonly' attribute to the input element.
Adding `margin-block-end` to the FormField wrapper, adding spacing between form fields. Also added additional styling to select and input fields inside the FormField, ensuring they grow to 100% the size of the FormField wrapper.
robinmolen
force-pushed
the
feature/12-information-page
branch
from
04bed34 to
33a4375
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partly closes #12
PR adds:
This PR requires maykinmedia/admin-ui#327 for the public url field