[hosting-logs] Add WithLogging#4483
Conversation
alanwest
left a comment
There was a problem hiding this comment.
WithLogging doesn't necessarily need to exist and/or doesn't need to turn on the ILogger integration
I understand what you're saying, but I will assert that it does need to exist. I think consistency is important. OpenTelemetry has conditioned folks to think about telemetry as metrics, traces, and logs. Good to reenforce that conditioning 😄
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4483 +/- ##
==========================================
+ Coverage 85.13% 85.28% +0.14%
==========================================
Files 315 315
Lines 12536 12549 +13
==========================================
+ Hits 10673 10702 +29
+ Misses 1863 1847 -16
|
|
FYI I pushed an update so that On that topic... What makes appBuilder.Services.AddOpenTelemetry()
.ConfigureResource(...)
.AddOtlpExporter() // Turns on OtlpExporter for all signals
.WithTracing()
.WithMetrics()
.WithLogging(); |
Relates to #4433
Changes
WithLoggingextension onOpenTelemetryBuilderDetails
We're getting into the more interesting bits of this effort!
The current design on this PR is these 3 things are equivalent:
Traditional API:
New API:
Both APIs:
WithLoggingdoesn't necessarily need to exist and/or doesn't need to turn on the ILogger integration. Discussed this with @noahfalk a bit and we felt this was reasonable. But open to ideas/discussions/suggestions.Merge requirement checklist