[hosting-logs] Improve the OpenTelemetryBuilder.ConfigureResource test#4485
Merged
utpilla merged 1 commit intoopen-telemetry:mainfrom May 15, 2023
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4485 +/- ##
==========================================
+ Coverage 85.20% 85.21% +0.01%
==========================================
Files 315 315
Lines 12549 12549
==========================================
+ Hits 10692 10694 +2
+ Misses 1857 1855 -2 |
vishweshbankwar
approved these changes
May 15, 2023
utpilla
approved these changes
May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on some feedback: #4483 (comment)
Changes
OpenTelemetryBuilder.ConfigureResourcetest to verify signal-specific attributes work as expected.Merge requirement checklist