Add semantic convention for faas.coldstart and container.id#909
Merged
MrAlias merged 3 commits intoopen-telemetry:masterfrom Jul 7, 2020
Merged
Conversation
matej-g
requested review from
Aneurysm9,
MrAlias,
evantorrie,
jmacd,
lizthegrey and
paivagustavo
as code owners
lizthegrey
approved these changes
Jul 6, 2020
Aneurysm9
approved these changes
Jul 7, 2020
evantorrie
approved these changes
Jul 7, 2020
jmacd
approved these changes
Jul 7, 2020
MrAlias
approved these changes
Jul 7, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following attributes in line with the specification changes:
faas.coldstart- Add span attribute to indicate cold starts of Function as a Service executions opentelemetry-specification#650container.id- Add semantic conventions for container id opentelemetry-specification#673Relates Issues
Resolves #888
Resolves #889