Skip to content

Add semantic conventions for container id#673

Merged
bogdandrutu merged 4 commits intoopen-telemetry:masterfrom
wangzlei:master
Jun 30, 2020
Merged

Add semantic conventions for container id#673
bogdandrutu merged 4 commits intoopen-telemetry:masterfrom
wangzlei:master

Conversation

@wangzlei
Copy link
Copy Markdown
Contributor

Currently Container Attributes in Resource have only container.name to represent the container instance. I am proposing adding container.id as a Container attribute.
Refer to docker documentation Container identification, Container's full-id, short-id and name are equivalent in docker CLI like 'docker info '. name is usually human readable and can be changed by command 'docker rename' during runtime.

And AWS X-ray uses container.id represent the container instance in ECS, adding container.id in OpenTelemetry would be great helpful for X-Ray.

@wangzlei wangzlei requested a review from a team June 25, 2020 21:31
@wangzlei wangzlei closed this Jun 26, 2020
@wangzlei wangzlei reopened this Jun 28, 2020
wangzlei and others added 2 commits June 29, 2020 11:33
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
@bogdandrutu bogdandrutu merged commit 4a2fd06 into open-telemetry:master Jun 30, 2020
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
* Add semantic conventions for container id

* Update specification/resource/semantic_conventions/README.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Update specification/resource/semantic_conventions/README.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
schmikei pushed a commit to schmikei/opentelemetry-specification that referenced this pull request Apr 17, 2025
* Add semantic conventions for container id

* Update specification/resource/semantic_conventions/README.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

* Update specification/resource/semantic_conventions/README.md

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants