Skip to content

reactor-netty HttpClient: client span includes subscribe time #6607

@lmolkova

Description

@lmolkova

A spin-off from #6593

Subscribe callback time is included in Http client span duration. Per offline conversation with @trask this violates the contract for HTTP client instrumentation and results in requestWithCallbackAndNoParent() test not working for netty after changing context propagation in #6593

E.g. if I do this:

HttpClient.ResponseReceiver<?> request = HttpClient.create().request(HttpMethod.valueOf("GET")).uri("https://blank.com");

request.responseSingle((resp, content) -> content.map(unused -> resp))
    .subscribe(
        response -> {
            try {
                Thread.sleep(1000);
            } catch (InterruptedException e) {
                throw new RuntimeException(e);
            }
        });

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions