Reactor instrumentation: do not make root context current#6593
Merged
trask merged 6 commits intoopen-telemetry:mainfrom Sep 14, 2022
Merged
Reactor instrumentation: do not make root context current#6593trask merged 6 commits intoopen-telemetry:mainfrom
trask merged 6 commits intoopen-telemetry:mainfrom
Conversation
Member
|
@lmolkova heads up, I merged main into your branch to fix CI |
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 23, 2022
…etry#6593) Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
…etry#6593) Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
…etry#6593) Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, reactor's fluxes can be created and subscribed for at startup, and live till application dies.
TracingSubscriberis created at subscription time and captures root context as current, but this context is likely irrelevant to the rest of the Flux lifetime.E.g. the receiver will read and process messages from the queue:
Now imagine we do something like this:
This change only prevents the root context from becoming current. But if subscribe happens in scope of some span, there is no reliable way to know if it's the correct one. If not, applications can work it around by
doesNotOverrideInnerCurrentSpansWithThereIsOuterCurrenttest