Skip to content

add daemon attribute to process.runtime.jvm.threads.count#6635

Merged
trask merged 2 commits intoopen-telemetry:mainfrom
tuhao1020:main
Sep 24, 2022
Merged

add daemon attribute to process.runtime.jvm.threads.count#6635
trask merged 2 commits intoopen-telemetry:mainfrom
tuhao1020:main

Conversation

@tuhao1020
Copy link
Copy Markdown

Signed-off-by: HaoTu haotu@alauda.io

#6561 has closed

Signed-off-by: HaoTu <haotu@alauda.io>
@tuhao1020 tuhao1020 requested a review from a team September 16, 2022 00:13
@tuhao1020
Copy link
Copy Markdown
Author

image

What is the problem? @trask

@trask
Copy link
Copy Markdown
Member

trask commented Sep 16, 2022

ya, this is not related to your PR, we will fix in main and let you know so you can pull in main after its fixed

@laurit
Copy link
Copy Markdown
Contributor

laurit commented Sep 18, 2022

@tuhao1020 jApiCmp issue should be fixed now, please rebase

@tuhao1020
Copy link
Copy Markdown
Author

@laurit done

Copy link
Copy Markdown
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jack-berg @jonatan-ivanov PTAL

@trask
Copy link
Copy Markdown
Member

trask commented Sep 23, 2022

@tuhao1020 would you mind also submitting a PR to update the spec?

@tuhao1020
Copy link
Copy Markdown
Author

@mateuszrzeszutek
Copy link
Copy Markdown
Member

@tuhao1020
Copy link
Copy Markdown
Author

@trask
Copy link
Copy Markdown
Member

trask commented Sep 24, 2022

@trask trask merged commit 878dfc3 into open-telemetry:main Sep 24, 2022
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 23, 2022
…etry#6635)

Signed-off-by: HaoTu <haotu@alauda.io>

open-telemetry#6561  has closed

Signed-off-by: HaoTu <haotu@alauda.io>
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
…etry#6635)

Signed-off-by: HaoTu <haotu@alauda.io>

open-telemetry#6561  has closed

Signed-off-by: HaoTu <haotu@alauda.io>
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
…etry#6635)

Signed-off-by: HaoTu <haotu@alauda.io>

open-telemetry#6561  has closed

Signed-off-by: HaoTu <haotu@alauda.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants