Skip to content

add jvm daemon threads instrumentation#6561

Closed
tuhao1020 wants to merge 47 commits intoopen-telemetry:mainfrom
tuhao1020:main
Closed

add jvm daemon threads instrumentation#6561
tuhao1020 wants to merge 47 commits intoopen-telemetry:mainfrom
tuhao1020:main

Conversation

@tuhao1020
Copy link
Copy Markdown

@tuhao1020 tuhao1020 commented Sep 8, 2022

Signed-off-by: HaoTu haotu@alauda.io

add jvm daemon threads instrumentation
d61af21 
Signed-off-by: HaoTu <haotu@alauda.io>
@tuhao1020 tuhao1020 requested a review from a team September 8, 2022 15:11
HaoTu added 3 commits September 9, 2022 00:39
reformat
8ac94a4 
Signed-off-by: HaoTu <haotu@alauda.io>
update unit test
1577f76 
Signed-off-by: HaoTu <haotu@alauda.io>
update unit test
c657677 
Signed-off-by: HaoTu <haotu@alauda.io>
@trask
Copy link
Copy Markdown
Member

trask commented Sep 8, 2022

I wonder if this would make sense as a boolean daemon attribute (dimension) on process.runtime.jvm.threads.count?

cc @jack-berg @jonatan-ivanov

@jack-berg
Copy link
Copy Markdown
Member

jack-berg commented Sep 8, 2022

I think that makes a lot of sense @trask. Can compute daemon vs. non-daemon with:

  • daemon: ThreadMXBead#getDaemonThreadCount()
  • non-daemon: ThreadMXBead#getThreadCount() - ThreadMXBead#getDaemonThreadCount()

reformat
738e02c 
Signed-off-by: HaoTu <haotu@alauda.io>
@jonatan-ivanov
Copy link
Copy Markdown
Member

jonatan-ivanov commented Sep 10, 2022

I agree, especially because that way it is easy to aggregate the daemon + non-daemon threads.

@tuhao1020
Copy link
Copy Markdown
Author

tuhao1020 commented Sep 13, 2022 •
edited
Loading

@trask @jack-berg @jonatan-ivanov Expect the following？

process.runtime.jvm.threads.count{daemon=true} 2
process.runtime.jvm.threads.count{daemon=false} 5

Should consider adding ThreadMXBean.getPeakThreadCount?

@jonatan-ivanov
Copy link
Copy Markdown
Member

jonatan-ivanov commented Sep 13, 2022

Yes, if you have 7 threads, 2 of them are daemon and 5 of them are not.

HaoTu added 4 commits September 13, 2022 15:01
Use daemon attribute to distinguish between daemon and non-daemon thr…
2b528fc 
…eads

Signed-off-by: HaoTu <haotu@alauda.io>
update unit test
f5fafcd 
Signed-off-by: HaoTu <haotu@alauda.io>
import package
8972d74 
Signed-off-by: HaoTu <haotu@alauda.io>
update example for process.runtime.jvm.threads.count
8008178 
Signed-off-by: HaoTu <haotu@alauda.io>
@tuhao1020
Copy link
Copy Markdown
Author

tuhao1020 commented Sep 13, 2022

@trask

FILE: ./docs/supported-libraries.md
ERROR: 1 dead links found!
  [x] https://www.ibm.com/cloud/websphere-application-server → Status: 404

update websphere link
8ffcaa2 
Signed-off-by: HaoTu <haotu@alauda.io>
@tuhao1020
Copy link
Copy Markdown
Author

tuhao1020 commented Sep 15, 2022

@trask @jack-berg @jonatan-ivanov Can anyeone help to review the code?

trask and others added 12 commits September 16, 2022 00:43
@trask
Add mongo sanitization configuration (#6541)
e10bb59
@jack-berg
Use micrometer library instrumentation in agent (#6560)
27ffc6a 
* Use micrometer library instrumentation in agent

* PR feedback
Add gradle plugin for SDK extensions (#6558)
afe323f
@trask
Add release cadence (#6565)
f21aa70
@trask
Remove a method from instrumenter api (#6570)
ad44de9
@trask
Stabilize instrumentation-api and introduce jApiCmp checks (#6566)
a95f178 
* Stabilize instrumentation-api and introduce jApiCmp checks

* Update

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@trask
Update to otel 1.18.0 (#6575)
654cd5e
@trask
Introduce non-alpha bom (#6576)
e259a1d
@trask
Move extractFromRequest() to internal (#6585)
664ec82 
* Move extractFromRequest() to internal

* Javadoc
@trask
Rename ErrorCauseExtractor.jdk() to getDefault() (#6580)
ef2792f 
* Rename ErrorCauseExtractor.jdk() to ErrorCauseExtractor.getDefault()

* jApiCmp
@trask
Rename two package-private instrumenter-api classes (#6579)
29bd87e
@trask
Fix jApiCmp CI check (#6577)
24cc82d
Mateusz Rzeszutek and others added 23 commits September 16, 2022 00:43
Remove agent's Ordered interface and use the SDK one (#6589)
b3c938b
@trask
Encapsulate logging (#6543)
dc9ac47 
* Encapsulate actual logging implementation better

* Apply suggestions from code review

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* code review comments

* revert to the old slf4j package name

* spotless

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@trask
Fix instrumentation-api-semconv packages (#6590)
4b68c1b 
* Fix instrumentation-api-semconv packages

* Move test

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@dependabot
Bump com.gradle.common-custom-user-data-gradle-plugin from 1.8 to 1.8…
c65dc5c 
….1 (#6596)

Bumps com.gradle.common-custom-user-data-gradle-plugin from 1.8 to 1.8.1.

---
updated-dependencies:
- dependency-name: com.gradle.common-custom-user-data-gradle-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Add kafka client metrics to the javaagent instrumentation (#6533)
fb07c44 
* Add kafka client metrics to the javaagent instrumentation

* Don't override user-set metrics reporter

* Add kafka metric reporter config property
Use ConditionalResourceProvider in the Spring Boot service name provi…
e04464c 
…der (#6587)

* Use ConditionalResourceProvider in the Spring Boot service name provider

* make it a bit simpler

* add order=100

* add comment

* spellcheck
@trask
Add experimental span attribute job.system (#6586)
876a562 
* Add experimental span attribute job.system

* spring-batch
@trask
Optimize ReactorNettyNetClientAttributesGetter (#6600)
09511c9 
* Optimize ReactorNettyNetClientAttributesGetter

* Update
@jeanbisutti @trask
Add code attributes for Logback (#6591)
8356fca 
* Add code attributes for Logback

* Rename property

* Add a note about performance

* Add null check on file name

* Add check on line number

* Fix test following new behavior

* spotless

* Update instrumentation/logback/logback-appender-1.0/library/src/main/java/io/opentelemetry/instrumentation/logback/appender/v1_0/internal/LoggingEventMapper.java

Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* Fix test

* Adapt test for Java 18

* codenarc

* Test fix

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
@trask
Remove external usages of ClassNames (and move it to internal) (#6584)
f84b933 
* Reduce dependency on simpleName

* Move ClassNames to internal

* Javadoc

* Updates

* Fix

* Spotless

* Rename

* Add test
@trask
Fix latest dep builds (#6603)
f200f9b 
* Fix latest dep builds

* fix couchbase 3.2 too

* codenarc

* fix jedis 4.0 tests

* fix restlet 2.0 tests

* fix armeria tests

* Update instrumentation/couchbase/couchbase-3.2/javaagent/src/test/groovy/CouchbaseClient32Test.groovy

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@laurit
Fix finatra latest deps test (#6616)
6e49edb
@trask
Add dependency from alpha bom to stable bom (#6611)
e9827ef
Some assertions refactoring (#6618)
68ef38b
@laurit
Fix spring boot @WithSpan handling (#6619)
e1d2f42
@trask
Convert logback test to Java (#6613)
618846c
@trask
Reactor instrumentation: do not make root context current (#6593)
b7da40f 
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@trask
Update change log for 1.18.0 release (#6564)
0b90409
@opentelemetrybot @trask
Update version to 1.19.0-SNAPSHOT (#6623)
b58d43c 
* Update version to 1.19.0-SNAPSHOT

* Update CHANGELOG.md

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@trask
Fix examples in main branch (#6626)
fb92615
@jack-berg
Add resource providers (#6574)
bc1e179 
* Add resource providers

* Use autoservice annotation
@trask
Fix operator pull request (#6629)
194af46
@trask
Fix at mention in operator pr (#6630)
169ffa1
@tuhao1020 tuhao1020 closed this by deleting the head repository Sep 15, 2022
@tuhao1020 tuhao1020 mentioned this pull request Sep 16, 2022
Merged
trask pushed a commit that referenced this pull request Sep 24, 2022
add daemon attribute to process.runtime.jvm.threads.count (#6635)
878dfc3 
Signed-off-by: HaoTu <haotu@alauda.io>

#6561  has closed

Signed-off-by: HaoTu <haotu@alauda.io>
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 23, 2022
@LironKS
add daemon attribute to process.runtime.jvm.threads.count (open-telem…
23dd7d7 
…etry#6635)

Signed-off-by: HaoTu <haotu@alauda.io>

open-telemetry#6561  has closed

Signed-off-by: HaoTu <haotu@alauda.io>
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
@LironKS
add daemon attribute to process.runtime.jvm.threads.count (open-telem…
3490fda 
…etry#6635)

Signed-off-by: HaoTu <haotu@alauda.io>

open-telemetry#6561  has closed

Signed-off-by: HaoTu <haotu@alauda.io>
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
@LironKS
add daemon attribute to process.runtime.jvm.threads.count (open-telem…
53eb672 
…etry#6635)

Signed-off-by: HaoTu <haotu@alauda.io>

open-telemetry#6561  has closed

Signed-off-by: HaoTu <haotu@alauda.io>
@jonatan-ivanov jonatan-ivanov mentioned this pull request Jun 15, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tuhao1020 @trask @jack-berg @jonatan-ivanov @jeanbisutti @laurit @opentelemetrybot