Add asyncclick instrumentation#3319
Merged
xrmx merged 5 commits intoopen-telemetry:mainfrom Mar 28, 2025
Merged
Conversation
jomcgi
force-pushed
the
feat-3318/asyncclick-autoinstrumentation
branch
from
874ba33 to
17b14da
Compare
jomcgi
force-pushed
the
feat-3318/asyncclick-autoinstrumentation
branch
5 times, most recently
from
a1b5c89 to
ff0d7fd
Compare
jomcgi
changed the title
jomcgi
changed the title
jomcgi
force-pushed
the
feat-3318/asyncclick-autoinstrumentation
branch
5 times, most recently
from
23d64e8 to
bac1c1b
Compare
jomcgi
force-pushed
the
feat-3318/asyncclick-autoinstrumentation
branch
from
d0b2350 to
ae61899
Compare
jomcgi
changed the title
xrmx
reviewed
Mar 7, 2025
...elemetry-instrumentation-asyncclick/src/opentelemetry/instrumentation/asyncclick/__init__.py
Outdated
Show resolved
Hide resolved
emdneto
reviewed
Mar 11, 2025
Member
emdneto
left a comment
emdneto
left a comment
There was a problem hiding this comment.
wdyt add that to the pyright strict list in pyproject.toml?
instrumentation/opentelemetry-instrumentation-asyncclick/README.rst
Outdated
Show resolved
Hide resolved
...elemetry-instrumentation-asyncclick/src/opentelemetry/instrumentation/asyncclick/__init__.py
Outdated
Show resolved
Hide resolved
jomcgi
force-pushed
the
feat-3318/asyncclick-autoinstrumentation
branch
from
ae61899 to
f0759b7
Compare
Contributor
Author
Done! |
jomcgi
force-pushed
the
feat-3318/asyncclick-autoinstrumentation
branch
from
f0759b7 to
9d09175
Compare
* Add instrumentation for asyncclick based CLI apps * Add tox * Add Changelog * Update workflows This implementation is based on the original click instrumentation work by: - Emídio Neto <9735060+emdneto@users.noreply.github.com> - Anuraag (Rag) Agrawal <anuraaga@gmail.com> - Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
jomcgi
force-pushed
the
feat-3318/asyncclick-autoinstrumentation
branch
from
9d09175 to
69d88e3
Compare
emdneto
reviewed
Mar 26, 2025
emdneto
reviewed
Mar 26, 2025
Member
emdneto
left a comment
emdneto
left a comment
There was a problem hiding this comment.
Thanks for the work so far on this one. I'll share this in SIG tomorrow and see if we can at least create the package in PyPI while this doesn't get merged.
Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
Contributor
Author
|
Thanks! I'll try to attend too. |
xrmx
reviewed
Mar 27, 2025
...elemetry-instrumentation-asyncclick/src/opentelemetry/instrumentation/asyncclick/__init__.py
Outdated
Show resolved
Hide resolved
xrmx
approved these changes
Mar 27, 2025
Contributor
xrmx
left a comment
xrmx
left a comment
There was a problem hiding this comment.
Other than the small nit in the example LGTM. Hopefully this is not used by long running servers and so we may never need to introduce code to disable the instrumentation in these cases.
emdneto
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This implementation is based on the original click instrumentation work by:
Fixes #3318
Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.