WSGI request/response hooks#424
Conversation
cc6260b to
fb7d281
Compare
srikanthccv
left a comment
There was a problem hiding this comment.
LGTM. I think one downside here is when a user has custom sampler which uses span name as a part of sampling decision then the default span name might not be really helpful. And any update_name calls can't change decision.
Updates the Span name. Upon this update, any sampling behavior based on Span name will depend on the implementation.
Note that Samplers can only consider information already present during span creation. Any changes done later, including updated span name, cannot change their decisions.
I don't see a workaround for this? If this is needed in the future, |
Description
Replaced WSGI name callback with request/response hooks
Fixes #409
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.