Exemplars SHOULD be on by default#3994
Merged
reyang merged 3 commits intoopen-telemetry:mainfrom Apr 16, 2024
Merged
Conversation
Member
From what I can tell... this was already a SHOULD! Did I miss something obvious? |
cijothomas
approved these changes
Apr 13, 2024
jack-berg
approved these changes
Apr 16, 2024
This was referenced Apr 17, 2024
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks #3870
Changes
Discussed during the Apr. 10th, 2024 Technical Committee Meeting, we'd like to move Exemplars specification to stable. To address the blocking concern #3870 (review), this PR updated the wording to "SHOULD be on" (instead of "MUST be on"), if certain SDK implementations have performance concerns, they can decide to ship a stable version with exemplars OFF by default, and switch to ON by default later once the perf issue is solved (which is not a breaking change as exemplars are best efforts).