Skip to content

Exemplars SHOULD be on by default #3994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reyang merged 3 commits into from
Apr 16, 2024
Merged

Exemplars SHOULD be on by default #3994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdc59e9
Exemplars SHOULD be on by default
reyang Apr 11, 2024
e5c9ed8
changelog
reyang Apr 11, 2024
4a4b980
Merge branch 'main' into reyang/exemplar-should-be-on-by-default
cijothomas Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ release.
([#3872](https://github.com/open-telemetry/opentelemetry-specification/pull/3872))
- Add synchronous gauge entry to sum monotonic table.
([#3977](https://github.com/open-telemetry/opentelemetry-specification/pull/3977))
- Change the exemplar behavior to be on by default.
([#3994](https://github.com/open-telemetry/opentelemetry-specification/pull/3994))

### Logs

Expand Down
2 changes: 1 addition & 1 deletion specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1005,7 +1005,7 @@ While the metric data point for the counter would carry the attributes `X` and
A Metric SDK MUST provide a mechanism to sample `Exemplar`s from measurements
via the `ExemplarFilter` and `ExemplarReservoir` hooks.

`Exemplar` sampling SHOULD be turned off by default. If `Exemplar` sampling is
`Exemplar` sampling SHOULD be turned on by default. If `Exemplar` sampling is
off, the SDK MUST NOT have overhead related to exemplar sampling.

A Metric SDK MUST allow exemplar sampling to leverage the configuration of
Expand Down