Skip to content

Move HTTP client metrics out of .NET conventions#801

Merged
lmolkova merged 10 commits intoopen-telemetry:mainfrom
dynatrace-oss-contrib:move-dotnet-metrics-experimental
Mar 14, 2024
Merged

Move HTTP client metrics out of .NET conventions#801
lmolkova merged 10 commits intoopen-telemetry:mainfrom
dynatrace-oss-contrib:move-dotnet-metrics-experimental

Conversation

@joaopgrassi
Copy link
Copy Markdown
Member

Fixes #800

Changes

This PR moves HTTP client metrics (and one attribute) from the .NET metrics model to the general HTTP one.

It removes MD generation from .NET metric definition as it's frozen in time and should not get any updates or changes on the common metric.

It helps to untie .NET semconv stability from the unstable OTel parts it depends upon and helps with #781

Related to #785

Merge requirement checklist

@joaopgrassi joaopgrassi requested review from a team March 7, 2024 10:44
@lmolkova
Copy link
Copy Markdown
Member

@antonfirsov could you please take another look?

@lmolkova
Copy link
Copy Markdown
Member

lmolkova commented Mar 12, 2024

also //cc @open-telemetry/dotnet-approvers @open-telemetry/semconv-dotnet-approver

@lmolkova lmolkova merged commit cfff890 into open-telemetry:main Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Move common HTTP client metrics out from .NET metrics definitions yaml

7 participants