Clarify that network.protocol.version represents negotiated version#817
Merged
joaopgrassi merged 2 commits intoopen-telemetry:mainfrom Mar 25, 2024
Merged
Conversation
Member
Author
|
@antonfirsov could you please take a look? Following up on your comment here #801 (comment) - .NET client metrics override the note already and this change would not affect them anyway. |
trisch-me
reviewed
Mar 14, 2024
trask
approved these changes
Mar 14, 2024
noahfalk
reviewed
Mar 15, 2024
Contributor
noahfalk
left a comment
noahfalk
left a comment
There was a problem hiding this comment.
This seems fine to me from the perspective the text seems clear. I'll defer to @antonfirsov and @JamesNK to ensure that the description matches what the implementation of HttpClient and Kestrel actually do.
Contributor
|
Looks ok to me. @antonfirsov is the client expert. |
Member
Author
|
@antonfirsov friendly ping |
antonfirsov
approved these changes
Mar 21, 2024
lmolkova
force-pushed
the
http-protocol-version-negotiated
branch
from
b243dd2 to
0220b1e
Compare
joaopgrassi
approved these changes
Mar 25, 2024
Member
|
Should we get more approvals from @open-telemetry/semconv-http-approvers ? Edit: All http approvers are already here :D |
lmolkova
force-pushed
the
http-protocol-version-negotiated
branch
from
0220b1e to
b4c60ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #686
Changes
Clarifies that
network.protocol.versionrepresents negotiated versionMerge requirement checklist
[chore]schema-next.yaml updated with changes to existing conventions.