fix(otel): make HTTP trace export survive app-server runtimes#14300
Merged
fix(otel): make HTTP trace export survive app-server runtimes#14300
Conversation
This was referenced Mar 11, 2026
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
pakrym-oai
reviewed
Mar 11, 2026
| } => { | ||
| debug!("Using OTLP Http exporter for traces: {endpoint}"); | ||
|
|
||
| if crate::otlp::current_tokio_runtime_is_multi_thread() { |
Collaborator
Author
There was a problem hiding this comment.
our main binaries are multi-threaded, but app-server-test-client and unit tests marked with just #[tokio::test] are single-threaded
pakrym-oai
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes OTLP HTTP trace export in runtimes where the previous exporter setup was unreliable, especially around app-server usage. It also removes the old
codex_otel::otel_providercompatibility shim and switches remaining call sites over to the crate-rootcodex_otel::OtelProviderexport.What changed
/v1/traces:codex_otel::otel_providershim and update remaining imports.Why
I hit cases where spans were being created correctly but never made it to the collector. The issue turned out to be in exporter/runtime behavior rather than the span plumbing itself. This PR narrows that gap and gives us regression coverage for the actual export path.