Merged
Conversation
Member
irtazaakram
commented
Sep 12, 2024
irtazaakram
commented
- Resolves Refactor Workflows #435
irtazaakram
force-pushed
the
refactor-workflows
branch
2 times, most recently
from
1a9b021 to
c0dd139
Compare
irtazaakram
force-pushed
the
refactor-workflows
branch
from
f7b1a6e to
e4f98cc
Compare
irtazaakram
commented
Oct 3, 2024
| django-version: ['django42'] | ||
| db-version: ['mysql80'] | ||
| python-version: ["3.11", "3.12"] | ||
| toxenv: ["django42"] # "quality", "pii_check", "check_keywords" |
Member
Author
There was a problem hiding this comment.
Will enable these checks in next PR as changes are quite a lot.
Member
Author
|
Hi @feanil, could you please review my PR when you have a moment? Thanks a lot! |
irtazaakram
added
hacktoberfest-accepted
feanil
reviewed
Oct 24, 2024
Contributor
feanil
left a comment
feanil
left a comment
There was a problem hiding this comment.
Generally looks good, just a couple of questions and one major suggestion and then I think this is good to go.
feanil
approved these changes
Oct 28, 2024
Contributor
|
Note that the approval is with the assumption that you'll update to using the docker containers for the ES and Mysql services. |
irtazaakram
force-pushed
the
refactor-workflows
branch
from
8a5c4a9 to
46fd01f
Compare
Member
Author
|
Hey @feanil, thanks for the review. Could you remove the required check |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.