[Remote Store] Fix stats reporting for multistream downloads.#10402
Merged
Rishikesh1159 merged 2 commits intoopensearch-project:mainfrom Oct 5, 2023
Merged
Conversation
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
7 tasks
Member
Author
|
This PR fixes the stats reporting for multistream downloads. I have tested the working of fix by following testing: Testing: -> Without this PR fix (download stats are empty for replicas): -> With this PR fix (download stats for replica are reported): |
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
andrross
reviewed
Oct 5, 2023
server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java
Show resolved
Hide resolved
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
71 tasks
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #10402 +/- ##
============================================
- Coverage 71.16% 71.15% -0.01%
- Complexity 58297 58375 +78
============================================
Files 4830 4843 +13
Lines 274903 275203 +300
Branches 40059 40068 +9
============================================
+ Hits 195637 195830 +193
- Misses 62882 62965 +83
- Partials 16384 16408 +24
|
kotwanikunal
approved these changes
Oct 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
* Fix stats reporting for multistream downloads. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * rename tracker to fileTransferTracker. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> --------- Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> (cherry picked from commit a3f8432) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
* Fix stats reporting for multistream downloads. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * rename tracker to fileTransferTracker. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> --------- Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> (cherry picked from commit a3f8432) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Rishikesh1159
pushed a commit
that referenced
this pull request
Oct 6, 2023
#10417) * Fix stats reporting for multistream downloads. * rename tracker to fileTransferTracker. --------- (cherry picked from commit a3f8432) Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal
pushed a commit
that referenced
this pull request
Oct 6, 2023
#10424) * Fix stats reporting for multistream downloads. * rename tracker to fileTransferTracker. --------- (cherry picked from commit a3f8432) Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaushalmahi12
pushed a commit
to kaushalmahi12/OpenSearch
that referenced
this pull request
Oct 6, 2023
…arch-project#10402) * Fix stats reporting for multistream downloads. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * rename tracker to fileTransferTracker. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> --------- Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
deshsidd
pushed a commit
to deshsidd/OpenSearch
that referenced
this pull request
Oct 9, 2023
…arch-project#10402) * Fix stats reporting for multistream downloads. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * rename tracker to fileTransferTracker. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> --------- Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
austintlee
pushed a commit
to austintlee/OpenSearch
that referenced
this pull request
Oct 23, 2023
…arch-project#10402) * Fix stats reporting for multistream downloads. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * rename tracker to fileTransferTracker. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> --------- Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
austintlee
pushed a commit
to austintlee/OpenSearch
that referenced
this pull request
Oct 23, 2023
…arch-project#10402) * Fix stats reporting for multistream downloads. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * rename tracker to fileTransferTracker. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> --------- Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
austintlee
pushed a commit
to austintlee/OpenSearch
that referenced
this pull request
Dec 13, 2023
…arch-project#10402) * Fix stats reporting for multistream downloads. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * rename tracker to fileTransferTracker. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> --------- Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
austintlee
pushed a commit
to austintlee/OpenSearch
that referenced
this pull request
Jan 19, 2024
…arch-project#10402) * Fix stats reporting for multistream downloads. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * rename tracker to fileTransferTracker. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> --------- Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
austintlee
pushed a commit
to austintlee/OpenSearch
that referenced
this pull request
Jan 19, 2024
…arch-project#10402) * Fix stats reporting for multistream downloads. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * rename tracker to fileTransferTracker. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> --------- Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
austintlee
pushed a commit
to austintlee/OpenSearch
that referenced
this pull request
Feb 6, 2024
…arch-project#10402) * Fix stats reporting for multistream downloads. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * rename tracker to fileTransferTracker. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> --------- Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
austintlee
pushed a commit
to austintlee/OpenSearch
that referenced
this pull request
Feb 6, 2024
…arch-project#10402) * Fix stats reporting for multistream downloads. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * rename tracker to fileTransferTracker. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> --------- Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…arch-project#10402) * Fix stats reporting for multistream downloads. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * rename tracker to fileTransferTracker. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> --------- Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR reports stats for multistream downloads. With addition of copyTo() in PR proper stats are no longer reported. This PR fixes the issue and reports proper stats.
Related Issues
Resolves #10283
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.