GHA to verify checklist items completion in PR descriptions by peternied · Pull Request #10800 · opensearch-project/OpenSearch

peternied · 2023-10-20T17:57:23Z

Description

GHA to verify checklist items completion in PR descriptions

Related Issues

GitHub Action: https://github.com/peternied/check-pull-request-description
Related Update Github pull request template to have a task for inspecting failing checks #10751

Check List

~~New functionality includes testing.~~
- ~~All tests pass~~
~~New functionality has been documented.~~
- ~~New functionality has javadoc added~~
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)
~~Public documentation issue/PR created~~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Job that verifies the description checklist items are completed or invalid Signed-off-by: Peter Nied <petern@amazon.com>

Signed-off-by: Peter Nied <petern@amazon.com>

github-actions · 2023-10-20T18:35:19Z

Compatibility status:

Checks if related components are compatible with change 158d0bd

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

github-actions · 2023-10-20T18:39:06Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/28624/
CommitID: b247947
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

.github/workflows/pull-request-checks.yml

github-actions · 2023-10-20T18:49:29Z

Gradle Check (Jenkins) Run Completed with:

RESULT: null ❌
URL: https://build.ci.opensearch.org/job/gradle-check/28625/
CommitID: c376211
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-10-20T18:52:12Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

URL: https://build.ci.opensearch.org/job/gradle-check/28626/
CommitID: bd9a6da
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2023-10-20T18:54:22Z

Codecov Report

Merging #10800 (158d0bd) into main (da85124) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main   #10800      +/-   ##
============================================
- Coverage     71.31%   71.16%   -0.15%     
+ Complexity    58711    58665      -46     
============================================
  Files          4869     4869              
  Lines        276489   276489              
  Branches      40202    40202              
============================================
- Hits         197183   196773     -410     
- Misses        62873    63300     +427     
+ Partials      16433    16416      -17

see 448 files with indirect coverage changes

github-actions · 2023-10-20T19:01:54Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/28627/
CommitID: 2aed037

github-actions · 2023-10-20T19:16:29Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/28629/
CommitID: c212a8b
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Signed-off-by: Peter Nied <petern@amazon.com>

.github/workflows/pull-request-checks.yml

github-actions · 2023-10-23T22:13:48Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      2 org.opensearch.search.SearchWeightedRoutingIT.testShardRoutingWithNetworkDisruption_FailOpenEnabled

URL: https://build.ci.opensearch.org/job/gradle-check/28873/
CommitID: 158d0bd
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

…ch-project#10800) Signed-off-by: Peter Nied <petern@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>

peternied added 7 commits October 20, 2023 17:54

Add workflow for pull request specific checks

b247947

Job that verifies the description checklist items are completed or invalid Signed-off-by: Peter Nied <petern@amazon.com>

Fix incorrect parameter

c376211

Signed-off-by: Peter Nied <petern@amazon.com>

Don't limit pull request trigger types

bd9a6da

Signed-off-by: Peter Nied <petern@amazon.com>

Add that missing 'i'

2aed037

Signed-off-by: Peter Nied <petern@amazon.com>

Small whitespace change

0219b46

Signed-off-by: Peter Nied <petern@amazon.com>

Update triggers for the pull request checks

c212a8b

Signed-off-by: Peter Nied <petern@amazon.com>

Format document

ce61acb

Signed-off-by: Peter Nied <petern@amazon.com>

peternied changed the title ~~Add workflow for pull request specific checks~~ GHA to verify checklist items completion in PR descriptions Oct 20, 2023

peternied commented Oct 20, 2023

View reviewed changes

.github/workflows/pull-request-checks.yml Outdated Show resolved Hide resolved

peternied added 2 commits October 23, 2023 21:20

Merge remote-tracking branch 'origin/main' into pull-request-checks

21a9a26

Signed-off-by: Peter Nied <petern@amazon.com>

Ready for merging

158d0bd

Signed-off-by: Peter Nied <petern@amazon.com>

peternied marked this pull request as ready for review October 23, 2023 21:29

peternied requested review from Bukhtawar, CEHENKLE, abbashus, anasalkouz, andrross, dblock, dbwiddis, dreamer-89, gbbafna, kartg and kotwanikunal as code owners October 23, 2023 21:29

peternied requested review from Rishikesh1159, VachaShah, mch2, msfroh, nknize, owaiskazi19, reta, ryanbogan, sachinpkale, saratvemulapalli, setiah, shwetathareja and sohami as code owners October 23, 2023 21:29

peternied commented Oct 23, 2023

View reviewed changes

.github/workflows/pull-request-checks.yml Show resolved Hide resolved

reta approved these changes Oct 24, 2023

View reviewed changes

peternied merged commit 5bd413c into opensearch-project:main Oct 24, 2023

peternied deleted the pull-request-checks branch October 24, 2023 11:38

shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024

GHA to verify checklist items completion in PR descriptions (opensear…

acfc6f5

…ch-project#10800) Signed-off-by: Peter Nied <petern@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>

BrewTestBot mentioned this pull request May 6, 2025

opensearch 3.0.0 Homebrew/homebrew-core#222665

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GHA to verify checklist items completion in PR descriptions#10800

GHA to verify checklist items completion in PR descriptions#10800
peternied merged 9 commits intoopensearch-project:mainfrom
peternied:pull-request-checks

peternied commented Oct 20, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Oct 20, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Oct 20, 2023

Uh oh!

Uh oh!

github-actions bot commented Oct 20, 2023

Uh oh!

github-actions bot commented Oct 20, 2023

Uh oh!

codecov bot commented Oct 20, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Oct 20, 2023

Uh oh!

github-actions bot commented Oct 20, 2023

Uh oh!

Uh oh!

github-actions bot commented Oct 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

peternied commented Oct 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Check List

Uh oh!

github-actions bot commented Oct 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Compatibility status:

Incompatible components

Skipped components

Compatible components

Uh oh!

github-actions bot commented Oct 20, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Uh oh!

github-actions bot commented Oct 20, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 20, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

codecov bot commented Oct 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Oct 20, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 20, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Uh oh!

github-actions bot commented Oct 23, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

peternied commented Oct 20, 2023 •

edited

Loading

github-actions bot commented Oct 20, 2023 •

edited

Loading

codecov bot commented Oct 20, 2023 •

edited

Loading