-
Notifications
You must be signed in to change notification settings - Fork 2.5k
GHA to verify checklist items completion in PR descriptions #10800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
peternied
merged 9 commits into
opensearch-project:main
from
peternied:pull-request-checks
Oct 24, 2023
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b247947
Add workflow for pull request specific checks
peternied c376211
Fix incorrect parameter
peternied bd9a6da
Don't limit pull request trigger types
peternied 2aed037
Add that missing 'i'
peternied 0219b46
Small whitespace change
peternied c212a8b
Update triggers for the pull request checks
peternied ce61acb
Format document
peternied 21a9a26
Merge remote-tracking branch 'origin/main' into pull-request-checks
peternied 158d0bd
Ready for merging
peternied File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| name: Pull Request Checks | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: | ||
| [ | ||
| opened, | ||
| edited, | ||
| review_requested, | ||
| synchronize, | ||
| reopened, | ||
| ready_for_review, | ||
| ] | ||
|
|
||
| jobs: | ||
| verify-description-checklist: | ||
| name: Verify Description Checklist | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: peternied/check-pull-request-description-checklist@v1 | ||
| with: | ||
| checklist-items: | | ||
| New functionality includes testing. | ||
| All tests pass | ||
| New functionality has been documented. | ||
| New functionality has javadoc added | ||
| Commits are signed per the DCO using --signoff | ||
| Commit changes are listed out in CHANGELOG.md file (See: [Changelog](../blob/main/CONTRIBUTING.md#changelog)) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.