[Backport 2.x] Mute flaky concurrent segment search tests pending fixes (#10437) by jed326 · Pull Request #11050 · opensearch-project/OpenSearch

jed326 · 2023-11-01T19:02:31Z

Description

Backport 9cb4f9d from #10437.

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)
Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2023-11-01T19:43:51Z

Compatibility status:

Checks if related components are compatible with change 66260ae

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

github-actions · 2023-11-01T19:57:02Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29444/
CommitID: 8ac49fa
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

jed326 · 2023-11-01T20:57:54Z

https://build.ci.opensearch.org/job/gradle-check/29444/

[BUG] org.opensearch.search.suggest.CompletionSuggestSearchIT.testSkipDuplicates is flaky #10798

github-actions · 2023-11-01T21:38:57Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29449/
CommitID: c6bd9bf
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-11-02T00:41:17Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29456/
CommitID: 0bea75c
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-11-02T17:42:14Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29479/
CommitID: bff20e0
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-11-02T18:31:18Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29482/
CommitID: de72d2d
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

peternied · 2023-11-02T23:33:16Z

Another failure on [BUG] org.opensearch.search.suggest.CompletionSuggestSearchIT.testSkipDuplicates is flaky #10798

Good news - PR for review to resolve it #11068 - want to take a look?

github-actions · 2023-11-03T00:29:26Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29504/
CommitID: de72d2d
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-11-03T04:24:10Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29511/
CommitID: de72d2d
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-11-03T07:20:31Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29516/
CommitID: de72d2d
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-11-03T12:18:51Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29522/
CommitID: de72d2d
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

peternied · 2023-11-03T16:48:55Z

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.

From https://build.ci.opensearch.org/job/gradle-check/29504/

[BUG] RemoteStoreRestoreIT tests are flaky - Missing cluster-manager, expected nodes #11085

From https://build.ci.opensearch.org/job/gradle-check/29511/

From https://build.ci.opensearch.org/job/gradle-check/29504/

[BUG] org.opensearch.search.suggest.CompletionSuggestSearchIT.testSkipDuplicates is flaky #10798

From https://build.ci.opensearch.org/job/gradle-check/29522/

[BUG] org.opensearch.search.suggest.CompletionSuggestSearchIT.testSkipDuplicates is flaky #10798

github-actions · 2023-11-03T17:23:06Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29524/
CommitID: de72d2d
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

peternied · 2023-11-03T18:09:53Z

@jed326 Can you merge or rebase from 2.x I'm seeing unrelated tests failures that were resolved such as #10955

…project#10437) * DiversifiedSamplerIT.testNestedSamples * QueryProfilePhaseTests.testMaxScore * QueryProfilePhaseTests.testCollapseQuerySearchResults * HighlighterSearchIT.testHighlightQueryRewriteDatesWithNow * FieldCapabilitiesIT.testWithIndexFilter * QueryProfilePhaseTests.testDisableTopScoreCollection Signed-off-by: Jay Deng <jayd0104@gmail.com>

jed326 · 2023-11-03T20:30:23Z

@peternied just rebased. Thanks!

codecov · 2023-11-03T20:30:24Z

Codecov Report

Merging #11050 (66260ae) into 2.x (e297b21) will increase coverage by 0.13%.
Report is 4 commits behind head on 2.x.
The diff coverage is 69.53%.

@@             Coverage Diff              @@
##                2.x   #11050      +/-   ##
============================================
+ Coverage     70.86%   71.00%   +0.13%     
- Complexity    58864    58903      +39     
============================================
  Files          4850     4851       +1     
  Lines        277900   278030     +130     
  Branches      40735    40766      +31     
============================================
+ Hits         196937   197417     +480     
+ Misses        64238    63822     -416     
- Partials      16725    16791      +66

Files	Coverage Δ
...g/opensearch/identity/shiro/ShiroTokenManager.java	`93.33% <100.00%> (+28.21%)`	⬆️
...a/org/opensearch/extensions/ExtensionsManager.java	`52.14% <100.00%> (+1.20%)`	⬆️
...g/opensearch/extensions/NoopExtensionsManager.java	`42.85% <100.00%> (ø)`
...rch/extensions/rest/RestActionsRequestHandler.java	`100.00% <100.00%> (ø)`
...org/opensearch/identity/noop/NoopTokenManager.java	`100.00% <100.00%> (+33.33%)`	⬆️
...rg/opensearch/identity/tokens/BearerAuthToken.java	`100.00% <100.00%> (ø)`
...g/opensearch/identity/tokens/OnBehalfOfClaims.java	`87.50% <87.50%> (ø)`
server/src/main/java/org/opensearch/node/Node.java	`85.22% <0.00%> (ø)`
...ensearch/extensions/rest/ExtensionRestRequest.java	`71.59% <33.33%> (-1.67%)`	⬇️
...org/opensearch/identity/tokens/BasicAuthToken.java	`80.00% <60.00%> (-7.50%)`	⬇️
... and 5 more

... and 452 files with indirect coverage changes

github-actions · 2023-11-03T21:16:22Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29527/
CommitID: 66260ae
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

jed326 · 2023-11-03T21:19:47Z

Again 😕

https://build.ci.opensearch.org/job/gradle-check/29527/

[BUG] org.opensearch.search.suggest.CompletionSuggestSearchIT.testSkipDuplicates is flaky #10798

github-actions · 2023-11-03T23:20:26Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/29532/
CommitID: 66260ae
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-11-04T00:27:04Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/29534/
CommitID: 66260ae

jed326 mentioned this pull request Nov 1, 2023

[Backport 2.x] Mute flaky concurrent segment search tests pending fixes #10472

Closed

jed326 added the skip-changelog label Nov 1, 2023

jed326 force-pushed the backport-10437 branch from 8ac49fa to c6bd9bf Compare November 1, 2023 20:56

jed326 force-pushed the backport-10437 branch from c6bd9bf to 0bea75c Compare November 2, 2023 00:13

jed326 force-pushed the backport-10437 branch from 0bea75c to bff20e0 Compare November 2, 2023 16:54

jed326 force-pushed the backport-10437 branch from bff20e0 to de72d2d Compare November 2, 2023 17:43

peternied changed the title ~~Mute flaky concurrent segment search tests pending fixes (#10437)~~ [Backport 2.x] Mute flaky concurrent segment search tests pending fixes (#10437) Nov 2, 2023

peternied approved these changes Nov 2, 2023

View reviewed changes

peternied self-assigned this Nov 2, 2023

jed326 marked this pull request as ready for review November 2, 2023 23:34

jed326 requested review from Bukhtawar, CEHENKLE, anasalkouz, andrross, dblock, gbbafna, kartg, kotwanikunal, mch2, nknize, reta and setiah as code owners November 2, 2023 23:34

jed326 requested review from Rishikesh1159, VachaShah, dbwiddis, dreamer-89, msfroh, owaiskazi19, ryanbogan, sachinpkale, saratvemulapalli, shwetathareja and sohami as code owners November 2, 2023 23:34

peternied mentioned this pull request Nov 3, 2023

[BUG] AzureBlobContainerRetriesTests.testReadRangeBlobWithRetries flaky test failure #6090

Closed

jed326 force-pushed the backport-10437 branch from de72d2d to 66260ae Compare November 3, 2023 20:30

jed326 mentioned this pull request Nov 5, 2023

Disable concurrent aggs for Diversified Sampler and Sampler aggs #11087

Merged

8 tasks

peternied merged commit 74d1bb1 into opensearch-project:2.x Nov 6, 2023

jed326 deleted the backport-10437 branch August 7, 2024 17:29

Conversation

jed326 commented Nov 1, 2023

Description

Check List

Uh oh!

github-actions bot commented Nov 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Compatibility status:

Incompatible components

Skipped components

Compatible components

Uh oh!

github-actions bot commented Nov 1, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

jed326 commented Nov 1, 2023

Uh oh!

github-actions bot commented Nov 1, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Nov 2, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Nov 2, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Nov 2, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

peternied commented Nov 2, 2023

Uh oh!

github-actions bot commented Nov 3, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Nov 3, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Nov 3, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Nov 3, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

peternied commented Nov 3, 2023

From https://build.ci.opensearch.org/job/gradle-check/29504/

From https://build.ci.opensearch.org/job/gradle-check/29511/

From https://build.ci.opensearch.org/job/gradle-check/29504/

From https://build.ci.opensearch.org/job/gradle-check/29522/

Uh oh!

github-actions bot commented Nov 3, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

peternied commented Nov 3, 2023

Uh oh!

jed326 commented Nov 3, 2023

Uh oh!

codecov bot commented Nov 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Nov 3, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

jed326 commented Nov 3, 2023

Uh oh!

github-actions bot commented Nov 3, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Nov 4, 2023

Gradle Check (Jenkins) Run Completed with:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Nov 1, 2023 •

edited

Loading

codecov bot commented Nov 3, 2023 •

edited

Loading