Remove compatibility checker#12971
Merged
dblock merged 1 commit intoopensearch-project:mainfrom Apr 16, 2024
Merged
Conversation
Signed-off-by: Peter Nied <petern@amazon.com>
github-actions
bot
added
Build
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
dblock
suggested changes
Mar 29, 2024
Member
dblock
left a comment
dblock
left a comment
There was a problem hiding this comment.
It doesn't look like there are any comments one way or another on the RFC. Can we please solicit at least some input? I'll add mine.
Member
Author
|
@dblock Isn't this PR a way to solicit additional feedback on the topic? 😉 |
Member
Author
|
@dblock Since we've added the Java API compatibility check [1], I think this workflow's purpose has been replaced with a more reliable process. What do you think about removing this less reliable and often ignored check? |
peternied
requested review from
andrross,
gaiksaya,
kotwanikunal,
mch2 and
reta
github-actions
bot
added
the
discuss
Member
|
+1. I was going through another PR today and I think the new mechanism serves its purpose well |
gaiksaya
approved these changes
Apr 16, 2024
dblock
approved these changes
Apr 16, 2024
This comment was marked as resolved.
This comment was marked as resolved.
peternied
added a commit
to peternied/OpenSearch-1
that referenced
this pull request
Apr 16, 2024
Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit a2f07ed)
8 tasks
peternied
added a commit
that referenced
this pull request
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I do not see much value in continuing to run the compatibility checker. The workflow adds additional comments and test results that are ignored even when they detect downstream failures.
Related Issues
Check List
New functionality includes testing.All tests passNew functionality has been documented.New functionality has javadoc addedCommit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.