Skip to content

[Backport 2.x] [segment replication] decouple the rateLimiter of segrep and recovery#13181

Merged
mch2 merged 2 commits into2.xfrom
backport/backport-12959-to-2.x
Apr 15, 2024
Merged

[Backport 2.x] [segment replication] decouple the rateLimiter of segrep and recovery#13181
mch2 merged 2 commits into2.xfrom
backport/backport-12959-to-2.x

Conversation

@opensearch-trigger-bot
Copy link
Copy Markdown
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Apr 14, 2024

Backport 6bc04b4 from #12959.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2024 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change 031698d

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 14, 2024

❕ Gradle check result for 429e144: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testWriteLargeBlob

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@mch2
Copy link
Copy Markdown
Member

mch2 commented Apr 15, 2024

breaking change workflow looks to be correctly identifying a breaking change - will make an update here to mitigate by overloading the method.

* What went wrong:
Execution failed for task ':server:japicmp'.
> A failure occurred while executing me.champeau.gradle.japicmp.JApiCmpWorkAction
   > Detected binary changes.
         - current: opensearch-2.14.0-SNAPSHOT.jar
         - baseline: opensearch-2.14.0-SNAPSHOT.jar.
     
     See failure report at file:///home/runner/work/OpenSearch/OpenSearch/server/build/reports/java-compatibility/report.html

github-actions bot and others added 2 commits April 15, 2024 10:19
@github-actions @mch2
[segment replication] decouple the rateLimiter of segrep and recovery (…
b12306c 
…#12959)

* [segment replication] decouple the rateLimiter of segrep and recovery (12939)

add setting "segrep.max_bytes_per_sec"

Signed-off-by: maxliu <ly_chinese@163.com>

* [segment replication] decouple the rateLimiter of segrep and recovery (12939)

use setting "indices.replication.max_bytes_per_sec" if enable "indices.replication.use_individual_rate_limiter"

Signed-off-by: maxliu <ly_chinese@163.com>

* [segment replication] decouple the rateLimiter of segrep and recovery (12939)

setting "indices.replication.max_bytes_per_sec" takes effect when not negative

Signed-off-by: maxliu <ly_chinese@163.com>

* [segment replication] decouple the rateLimiter of segrep and recovery (#12939)

add setting "indices.replication.max_bytes_per_sec" which takes effect when not negative

Signed-off-by: maxliu <ly_chinese@163.com>

Adds change log

Signed-off-by: maxliu <ly_chinese@163.com>

---------

Signed-off-by: maxliu <ly_chinese@163.com>
(cherry picked from commit 6bc04b4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@mch2
Add back public API in RecoverySettings to 2.x
031698d 
Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
@mch2 mch2 force-pushed the backport/backport-12959-to-2.x branch from 429e144 to 031698d Compare April 15, 2024 17:29
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2024

❕ Gradle check result for 031698d: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.get_field_mapping/20_missing_field/Return empty object if field doesn't exist, but index does}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@mch2 mch2 merged commit c295d97 into 2.x Apr 15, 2024
@mch2 mch2 deleted the backport/backport-12959-to-2.x branch April 15, 2024 20:29
@kotwanikunal kotwanikunal mentioned this pull request Apr 16, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mch2 mch2 mch2 approved these changes

@kotwanikunal kotwanikunal kotwanikunal approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mch2 @kotwanikunal