[Backport 2.x] Add capability to disable source recovery_source for an index (#13590) by navneet1v · Pull Request #14064 · opensearch-project/OpenSearch

navneet1v · 2024-06-07T06:51:00Z

Description

Backport of the PR: #13590

Related Issues

NA

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)
Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

navneet1v · 2024-06-07T06:52:05Z

@reta , @msfroh can I get a review on this backport PR. The automated backport failed.

github-actions · 2024-06-07T07:23:40Z

❌ Gradle check result for 05b4b6b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-06-07T07:55:17Z

❌ Gradle check result for d576b6a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

reta · 2024-06-07T11:54:41Z

@reta , @msfroh can I get a review on this backport PR. The automated backport failed.

@navneet1v sure, needs #14072 :(

navneet1v · 2024-06-07T17:07:42Z

@reta , @msfroh can I get a review on this backport PR. The automated backport failed.

@navneet1v sure, needs #14072 :(

Oh. will wait for your PR to be merged and will trigger gradle check again.

navneet1v · 2024-06-08T20:35:41Z

❌ Gradle check result for 7dbc163: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

trying again.

github-actions · 2024-06-08T21:32:16Z

❌ Gradle check result for c91a26a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

navneet1v · 2024-06-08T22:06:58Z

❌ Gradle check result for c91a26a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test: #13828

github-actions · 2024-06-08T23:11:22Z

❌ Gradle check result for ca1b7e9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-06-09T08:26:44Z

❌ Gradle check result for a4e4540: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

github-actions · 2024-06-10T08:27:21Z

❌ Gradle check result for b27a5b4: TIMEOUT

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…arch-project#13590) Signed-off-by: Navneet Verma <navneev@amazon.com>

github-actions · 2024-06-11T00:07:09Z

❌ Gradle check result for d152e4a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

andrross · 2024-06-11T00:19:10Z

❌ Gradle check result for d152e4a: FAILURE

#12197

navneet1v · 2024-06-11T00:33:16Z

@andrross should I do a force push again to re-run gradle check.. :(

github-actions · 2024-06-11T01:14:03Z

✅ Gradle check result for d152e4a: SUCCESS

codecov · 2024-06-11T01:16:03Z

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.37%. Comparing base (0dd892c) to head (d152e4a).
Report is 340 commits behind head on 2.x.

Files	Patch %	Lines
...org/opensearch/index/mapper/SourceFieldMapper.java	93.75%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x   #14064      +/-   ##
============================================
+ Coverage     71.28%   71.37%   +0.09%     
- Complexity    60145    61821    +1676     
============================================
  Files          4957     5071     +114     
  Lines        282799   290423    +7624     
  Branches      41409    42342     +933     
============================================
+ Hits         201591   207298    +5707     
- Misses        64189    65691    +1502     
- Partials      17019    17434     +415

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

navneet1v · 2024-06-11T01:23:10Z

@andrross, @reta , @msfroh I can see a successful gradle check. can we merge this PR?

…arch-project#13590) (opensearch-project#14064) Signed-off-by: Navneet Verma <navneev@amazon.com> Signed-off-by: kkewwei <kkewwei@163.com>

navneet1v requested review from Bukhtawar, CEHENKLE, Rishikesh1159, VachaShah, anasalkouz, andrross, dblock, dbwiddis, dreamer-89, gbbafna, kotwanikunal, mch2, msfroh, nknize, owaiskazi19, reta, sachinpkale, saratvemulapalli, shwetathareja, sohami and tlfeng as code owners June 7, 2024 06:51

navneet1v added v2.15.0 Issues and PRs related to version 2.15.0 enhancement Enhancement or improvement to existing feature or request Indexing:Performance labels Jun 7, 2024

navneet1v force-pushed the 2.x branch from 05b4b6b to d576b6a Compare June 7, 2024 07:31

navneet1v force-pushed the 2.x branch from 7dbc163 to c91a26a Compare June 8, 2024 20:36

navneet1v force-pushed the 2.x branch from c91a26a to ca1b7e9 Compare June 8, 2024 22:08

navneet1v force-pushed the 2.x branch from ca1b7e9 to a4e4540 Compare June 9, 2024 07:34

navneet1v force-pushed the 2.x branch from a4e4540 to b27a5b4 Compare June 10, 2024 06:25

Add capability to disable source recovery_source for an index (opense…

d152e4a

…arch-project#13590) Signed-off-by: Navneet Verma <navneev@amazon.com>

navneet1v force-pushed the 2.x branch from b27a5b4 to d152e4a Compare June 10, 2024 23:15

reta approved these changes Jun 11, 2024

View reviewed changes

shwetathareja merged commit 6de0fae into opensearch-project:2.x Jun 11, 2024

prudhvigodithi mentioned this pull request Jun 14, 2024

[AUTOCUT] Gradle Check Flaky Test Report for IndicesRequestCacheIT prudhvigodithi/OpenSearch#27

Closed

Conversation

navneet1v commented Jun 7, 2024

Description

Related Issues

Check List

Uh oh!

navneet1v commented Jun 7, 2024

Uh oh!

github-actions bot commented Jun 7, 2024

Uh oh!

github-actions bot commented Jun 7, 2024

Uh oh!

reta commented Jun 7, 2024

Uh oh!

navneet1v commented Jun 7, 2024

Uh oh!

navneet1v commented Jun 8, 2024

Uh oh!

github-actions bot commented Jun 8, 2024

Uh oh!

navneet1v commented Jun 8, 2024

Uh oh!

github-actions bot commented Jun 8, 2024

Uh oh!

github-actions bot commented Jun 9, 2024

Uh oh!

github-actions bot commented Jun 10, 2024

Uh oh!

github-actions bot commented Jun 11, 2024

Uh oh!

andrross commented Jun 11, 2024

Uh oh!

navneet1v commented Jun 11, 2024

Uh oh!

github-actions bot commented Jun 11, 2024

Uh oh!

codecov bot commented Jun 11, 2024

Codecov Report

Uh oh!

navneet1v commented Jun 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants