Read write ephemeral objects for remote publication of cluster state#14089
Merged
shwetathareja merged 13 commits intoopensearch-project:mainfrom Jun 11, 2024
Merged
Read write ephemeral objects for remote publication of cluster state#14089shwetathareja merged 13 commits intoopensearch-project:mainfrom
shwetathareja merged 13 commits intoopensearch-project:mainfrom
Conversation
Contributor
|
❌ Gradle check result for 4671704: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❌ Gradle check result for d7c25e6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
himshikha
reviewed
Jun 8, 2024
server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
Outdated
Show resolved
Hide resolved
himshikha
reviewed
Jun 8, 2024
server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
Outdated
Show resolved
Hide resolved
himshikha
reviewed
Jun 8, 2024
server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
Outdated
Show resolved
Hide resolved
himshikha
reviewed
Jun 8, 2024
server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
Outdated
Show resolved
Hide resolved
alchemist51
force-pushed
the
read_write_ephemeral
branch
from
d7c25e6 to
3467ca7
Compare
Contributor
|
❌ Gradle check result for 3467ca7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
shiv0408
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
tlfeng
as code owners
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Contributor
|
❌ Gradle check result for 0391436: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❕ Gradle check result for 7a05c8e: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14089 +/- ##
============================================
+ Coverage 71.42% 71.64% +0.22%
- Complexity 59978 61967 +1989
============================================
Files 4985 5117 +132
Lines 282275 291579 +9304
Branches 40946 42150 +1204
============================================
+ Hits 201603 208902 +7299
- Misses 63999 65421 +1422
- Partials 16673 17256 +583 ☔ View full report in Codecov by Sentry. |
Member
|
PR has an approval from @Bukhtawar . Providing it another approval to unblock merge as some test fix went in since the last approval. |
shwetathareja
approved these changes
Jun 11, 2024
Member
shwetathareja
left a comment
shwetathareja
left a comment
There was a problem hiding this comment.
Providing approval to unblock merge.
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
…14089) * Read and write ephemeral objects for remote publication Co-authored-by: Sooraj Sinha <soosinha@amazon.com> Co-authored-by: Arpit Bandejiya <abandeji@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Add serde logic for hashes of consistent settings Signed-off-by: Sooraj Sinha <soosinha@amazon.com> * Add formattedName to readAsync for IndexMetadata Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 990ddc3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Jun 12, 2024
soosinha
pushed a commit
to soosinha/OpenSearch
that referenced
this pull request
Jun 12, 2024
…pensearch-project#14089) * Read and write ephemeral objects for remote publication Co-authored-by: Sooraj Sinha <soosinha@amazon.com> Co-authored-by: Arpit Bandejiya <abandeji@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Add serde logic for hashes of consistent settings Signed-off-by: Sooraj Sinha <soosinha@amazon.com> * Add formattedName to readAsync for IndexMetadata Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 990ddc3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shwetathareja
pushed a commit
that referenced
this pull request
Jun 12, 2024
…14089) (#14209) * Read and write ephemeral objects for remote publication Co-authored-by: Sooraj Sinha <soosinha@amazon.com> Co-authored-by: Arpit Bandejiya <abandeji@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Add serde logic for hashes of consistent settings Signed-off-by: Sooraj Sinha <soosinha@amazon.com> * Add formattedName to readAsync for IndexMetadata Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 990ddc3) Signed-off-by: Shivansh Arora <hishiv@amazon.com>
shwetathareja
pushed a commit
that referenced
this pull request
Jun 12, 2024
…14089) (#14207) * Read and write ephemeral objects for remote publication Co-authored-by: Sooraj Sinha <soosinha@amazon.com> Co-authored-by: Arpit Bandejiya <abandeji@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Add serde logic for hashes of consistent settings Signed-off-by: Sooraj Sinha <soosinha@amazon.com> * Add formattedName to readAsync for IndexMetadata Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 990ddc3) Signed-off-by: Shivansh Arora <hishiv@amazon.com>
3 tasks
This was referenced Jun 13, 2024
3 tasks
This was referenced Jun 17, 2024
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Jul 12, 2024
…pensearch-project#14089) * Read and write ephemeral objects for remote publication Co-authored-by: Sooraj Sinha <soosinha@amazon.com> Co-authored-by: Arpit Bandejiya <abandeji@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Add serde logic for hashes of consistent settings Signed-off-by: Sooraj Sinha <soosinha@amazon.com> * Add formattedName to readAsync for IndexMetadata Signed-off-by: Shivansh Arora <hishiv@amazon.com>
ashking94
reviewed
Jul 18, 2024
server/src/main/java/org/opensearch/gateway/remote/RemoteClusterStateService.java
Show resolved
Hide resolved
3 tasks
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…pensearch-project#14089) (opensearch-project#14207) * Read and write ephemeral objects for remote publication Co-authored-by: Sooraj Sinha <soosinha@amazon.com> Co-authored-by: Arpit Bandejiya <abandeji@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Add serde logic for hashes of consistent settings Signed-off-by: Sooraj Sinha <soosinha@amazon.com> * Add formattedName to readAsync for IndexMetadata Signed-off-by: Shivansh Arora <hishiv@amazon.com> (cherry picked from commit 990ddc3) Signed-off-by: Shivansh Arora <hishiv@amazon.com> Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…pensearch-project#14089) * Read and write ephemeral objects for remote publication Co-authored-by: Sooraj Sinha <soosinha@amazon.com> Co-authored-by: Arpit Bandejiya <abandeji@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com> * Add serde logic for hashes of consistent settings Signed-off-by: Sooraj Sinha <soosinha@amazon.com> * Add formattedName to readAsync for IndexMetadata Signed-off-by: Shivansh Arora <hishiv@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The changes include modification in
RemoteClusterStateServiceto enable uploading the ephemeral objects required for publication of cluster state through remote store. Also, added a method to read the Cluster State Attributes such as IndexMetadata, GlobalMetadata attributes from remote store in parallel. Read will be crucial part for publication as each follower node will be downloading the updated state from remote.Related Issues
Resolves #13728
Resolves #13729
Resolves #14109
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.