Skip to content

[Backport 2.x] Use correct names for snapshot indices while updating remote store index settings #14166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gbbafna merged 1 commit into from
Jun 11, 2024
Merged

[Backport 2.x] Use correct names for snapshot indices while updating remote store index settings #14166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/src/main/java/org/opensearch/snapshots/RestoreService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,7 +716,7 @@ private Settings getOverrideSettingsInternal() {
clusterService.state(),
clusterSettings,
clusterService.getSettings(),
request.getDescription()
String.join(",", request.indices())
);
return settingsBuilder.build();
}
Expand Down
4 changes: 2 additions & 2 deletions server/src/test/java/org/opensearch/cluster/metadata/MetadataCreateIndexServiceTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1603,7 +1603,7 @@ public void testNewIndexIsRemoteStoreBackedForRemoteStoreDirectionAndMixedMode()

ClusterSettings clusterSettings = new ClusterSettings(Settings.EMPTY, ClusterSettings.BUILT_IN_CLUSTER_SETTINGS);

request = new CreateIndexClusterStateUpdateRequest("create index", "test", "test");
request = new CreateIndexClusterStateUpdateRequest("create index", "test-index", "test-index");

Settings indexSettings = aggregateIndexSettings(
clusterState,
Expand Down Expand Up @@ -1684,7 +1684,7 @@ public void testNewIndexIsRemoteStoreBackedForRemoteStoreDirectionAndMixedMode()
finalClusterSettings
);
});

assertEquals(error.getMessage(), "failed to create index [test-index]");
assertThat(
error.getCause().getMessage(),
containsString("Cluster is migrating to remote store but no remote node found, failing index creation")
Expand Down