Add more yaml rest tests for search backpressure settings#16012
Merged
gaobinlong merged 1 commit intoopensearch-project:mainfrom Sep 20, 2024
Merged
Add more yaml rest tests for search backpressure settings#16012gaobinlong merged 1 commit intoopensearch-project:mainfrom
gaobinlong merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16012 +/- ##
============================================
+ Coverage 71.96% 72.07% +0.11%
- Complexity 64391 64460 +69
============================================
Files 5280 5280
Lines 300866 300871 +5
Branches 43474 43474
============================================
+ Hits 216510 216848 +338
+ Misses 66639 66275 -364
- Partials 17717 17748 +31 ☔ View full report in Codecov by Sentry. |
reta
approved these changes
Sep 20, 2024
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16012-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4963792c175ab3eb30a493e81360dce95b5b2811
# Push it to GitHub
git push --set-upstream origin backport/backport-16012-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
gaobinlong
added a commit
to gaobinlong/OpenSearch
that referenced
this pull request
Sep 20, 2024
…-project#16012) Signed-off-by: Gao Binlong <gbinlong@amazon.com> (cherry picked from commit 4963792)
reta
pushed a commit
that referenced
this pull request
Sep 20, 2024
amberzsy
pushed a commit
to amberzsy/OpenSearch-public
that referenced
this pull request
Sep 22, 2024
…-project#16012) Signed-off-by: Gao Binlong <gbinlong@amazon.com>
ruai0511
pushed a commit
to ruai0511/OpenSearch
that referenced
this pull request
Oct 4, 2024
…-project#16012) Signed-off-by: Gao Binlong <gbinlong@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…-project#16012) Signed-off-by: Gao Binlong <gbinlong@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…-project#16012) Signed-off-by: Gao Binlong <gbinlong@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…-project#16012) Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Merged
1 task
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Jan 21, 2025
…-project#16012) Signed-off-by: Gao Binlong <gbinlong@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Search backpressure feature has more than 10 cluster level settings but has less yaml rest test cases for them, even though we've added some tests in this PR:https://github.com/opensearch-project/OpenSearch/pull/15501/files, but it doesn't cover all settings, this PR aims to add yaml rest tests for all search backpressure settings, and move the tests from the directory
cluster.put_settingto its own directorysearch.backpressure.Besides, correct the supported version in the test case
Test set invalid search backpressure modefrom2.9.0to2.8.0.Changelog is not needed, backport to 2.x is needed.
Related Issues
No issue.
Check List
- [ ] Functionality includes testing.
- [ ] API changes companion pull request created, if applicable.
- [ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.