Fix IndicesRequestCacheIT flaky tests#16276
Merged
dbwiddis merged 2 commits intoopensearch-project:mainfrom Oct 12, 2024
Merged
Fix IndicesRequestCacheIT flaky tests#16276dbwiddis merged 2 commits intoopensearch-project:mainfrom
dbwiddis merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Contributor
|
❌ Gradle check result for 10c3dd2: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
dbwiddis
approved these changes
Oct 11, 2024
Member
dbwiddis
left a comment
There was a problem hiding this comment.
LGTM as an attempt to fix. How are we tracking the follow-up (does this work? If not should we revert?)
Contributor
|
@sgup432 - Seems you're missing the lucene version upgrade changes from main: |
Contributor
Author
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16276 +/- ##
============================================
- Coverage 72.06% 71.99% -0.07%
+ Complexity 64822 64789 -33
============================================
Files 5308 5308
Lines 302574 302565 -9
Branches 43710 43710
============================================
- Hits 218048 217845 -203
- Misses 66648 66841 +193
- Partials 17878 17879 +1 ☔ View full report in Codecov by Sentry. |
dbwiddis
approved these changes
Oct 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 12, 2024
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> (cherry picked from commit 20536ee) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Oct 12, 2024
(cherry picked from commit 20536ee) Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Jan 21, 2025
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes an attempt to fix two flaky test in IndicesRequestCacheIT mentioned here
I was not able to reproduce this even when running these tests for more than 500 iterations. So pretty rare. But the fix is based on a pretty good assumption that it will work. Also considering experience with fixing such similar tests successfully in the past.
Details below:
SearchTimeoutITwhich works fine.Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.