Deprecate performing update operation with default pipeline or final pipeline#16712
Merged
reta merged 5 commits intoopensearch-project:mainfrom Dec 2, 2024
Merged
Deprecate performing update operation with default pipeline or final pipeline#16712reta merged 5 commits intoopensearch-project:mainfrom
reta merged 5 commits intoopensearch-project:mainfrom
Conversation
…pipeline Signed-off-by: Gao Binlong <gbinlong@amazon.com>
4 tasks
Contributor
|
❕ Gradle check result for 77c599c: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16712 +/- ##
============================================
+ Coverage 72.06% 72.14% +0.07%
- Complexity 65177 65213 +36
============================================
Files 5318 5318
Lines 303983 303988 +5
Branches 43986 43987 +1
============================================
+ Hits 219073 219304 +231
+ Misses 66964 66736 -228
- Partials 17946 17948 +2 ☔ View full report in Codecov by Sentry. |
reta
reviewed
Nov 23, 2024
server/src/main/java/org/opensearch/action/update/TransportUpdateAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Contributor
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Contributor
|
❕ Gradle check result for b5c1a07: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
reta
approved these changes
Dec 2, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
…pipeline (#16712) * Deprecate performing update operation with default pipeline or final pipeline Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify the warning message Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify changelog Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Fix test issue Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> (cherry picked from commit d2a1477) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
added a commit
that referenced
this pull request
Dec 2, 2024
…eline or final pipeline (#16756) * Deprecate performing update operation with default pipeline or final pipeline (#16712) * Deprecate performing update operation with default pipeline or final pipeline Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify the warning message Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify changelog Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Fix test issue Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> (cherry picked from commit d2a1477) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update 75_update.yml Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
3 tasks
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Jan 21, 2025
…pipeline (opensearch-project#16712) * Deprecate performing update operation with default pipeline or final pipeline Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify the warning message Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Modify changelog Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Fix test issue Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com>
This was referenced Jan 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update API doesn't support ingest pipeline, but when there's a default pipeline or a final pipeline in the index and the specified document exists, the default pipeline or final pipeline will be executed, this behavior is unexpected and not consistent with the bulk API, we need to make the indexing result consistent in both APIs, so we need to change the behavior in Update API, we deprecate the support in Update API firstly and remove the support in 3.0.0 because it's a breaking change for some users.
Related Issues
#16663
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.