Skip to content

[Backport 2.x] Fix remote shards balance#16972

Merged
andrross merged 2 commits intoopensearch-project:2.xfrom
bugmakerrrrrr:backport/backport-15335-to-2.x
Jan 13, 2025
Merged

[Backport 2.x] Fix remote shards balance#16972
andrross merged 2 commits intoopensearch-project:2.xfrom
bugmakerrrrrr:backport/backport-15335-to-2.x

Conversation

@bugmakerrrrrr
Copy link
Copy Markdown
Contributor

@bugmakerrrrrr bugmakerrrrrr commented Jan 7, 2025

Description

backport #15335

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@bugmakerrrrrr @andrross
Fix remote shards balance (opensearch-project#15335)
fc51b60 
* Fix remote shards balance

Signed-off-by: panguixin <panguixin@bytedance.com>

* add changelog

Signed-off-by: panguixin <panguixin@bytedance.com>

---------

Signed-off-by: panguixin <panguixin@bytedance.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
Co-authored-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit b359dd8)
@bugmakerrrrrr bugmakerrrrrr mentioned this pull request Jan 7, 2025
Merged
3 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 7, 2025

❌ Gradle check result for fc51b60: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

kotwanikunal
kotwanikunal approved these changes Jan 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kotwanikunal kotwanikunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @bugmakerrrrrr!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 8, 2025

✅ Gradle check result for fc51b60: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.81%. Comparing base (8a17b8a) to head (db04416).
Report is 12 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ing/allocation/allocator/RemoteShardsBalancer.java 55.55% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #16972      +/-   ##
============================================
- Coverage     71.85%   71.81%   -0.05%     
- Complexity    65507    65512       +5     
============================================
  Files          5316     5316              
  Lines        305588   305595       +7     
  Branches      44516    44518       +2     
============================================
- Hits         219572   219450     -122     
- Misses        67674    67857     +183     
+ Partials      18342    18288      -54

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross
Merge branch '2.x' into backport/backport-15335-to-2.x
db04416 
Signed-off-by: Andrew Ross <andrross@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 8, 2025

❌ Gradle check result for db04416: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 10, 2025

✅ Gradle check result for db04416: SUCCESS

@andrross andrross merged commit a83f9e0 into opensearch-project:2.x Jan 13, 2025
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jan 14, 2025
Open
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Dec 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrross andrross andrross approved these changes

@kotwanikunal kotwanikunal kotwanikunal approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bugmakerrrrrr @andrross @kotwanikunal