Remove deprecated settings to defer cluster recovery#17357
Merged
andrross merged 1 commit intoopensearch-project:mainfrom Feb 14, 2025
Merged
Remove deprecated settings to defer cluster recovery#17357andrross merged 1 commit intoopensearch-project:mainfrom
andrross merged 1 commit intoopensearch-project:mainfrom
Conversation
andrross
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
ashking94,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
github-actions
bot
added
Cluster Manager
deprecate
enhancement
The following settings were deprecated in ES 7.7 prior to the fork: - gateway.expected_nodes - gateway.expected_master_nodes - gateway.recover_after_nodes - gateway.recover_after_master_nodes This commit removes the deprecated settings and replaces their usages in tests with `recover_after_data_nodes`. Signed-off-by: Andrew Ross <andrross@amazon.com>
Contributor
|
❕ Gradle check result for 34e05f6: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
andrross
force-pushed
the
remove-deprecated-gateway-settings
branch
from
34e05f6 to
99b25aa
Compare
Contributor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17357 +/- ##
============================================
- Coverage 72.41% 72.37% -0.04%
+ Complexity 65569 65530 -39
============================================
Files 5291 5291
Lines 304338 304312 -26
Branches 44181 44176 -5
============================================
- Hits 220376 220238 -138
- Misses 65917 66001 +84
- Partials 18045 18073 +28 ☔ View full report in Codecov by Sentry. |
reta
approved these changes
Feb 14, 2025
This was referenced Feb 19, 2025
1 task
bugfood
added a commit
to bugfood/puppet-opensearch
that referenced
this pull request
Feb 9, 2026
Compare: https://docs.opensearch.org/3.2/install-and-configure/configuring-opensearch/discovery-gateway-settings/ To: https://docs.opensearch.org/3.3/install-and-configure/configuring-opensearch/discovery-gateway-settings/ gateway.recover_after_nodes is now gone, probably due to: opensearch-project/OpenSearch#17357 The value of 0 here is documented to have been the default in 3.2 (and presumably earlier versions). This option may be replaceable by gateway.recover_after_data_nodes. Don't configure that as a default within puppet-opensearch, though; we don't need to mirror every upstream default here (indeed, the other gateway options are already unspecified).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following settings were deprecated in ES 7.7 prior to the fork:
This commit removes the deprecated settings and replaces their usages in tests with
expected_data_nodesorrecover_after_data_nodes.Related Issues
Resolves #3117
Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.