Fix Flaky Test testPendingTasksWithClusterNotRecoveredBlock

[kkewwei]

Description

There is a situation where the cluster contains 4 nodes, nodeCount=4, dataNodeCount=3
node0(role=cluster_manager)
node1(role=cluster_manager,data)
node2(role=cluster_manager,data)
node3(role=data)

if gateway.recover_after_data_nodes= 5(nodeCount + 1), when we startDataOnlyNode, dataNodeCount=4, we will never performing state recovery.

Related Issues

Resolves #17369

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[kkewwei]

@andrross, please have look when you are free, it seems be caused by #17357

[cwperks]

@kkewwei Thank you for taking a look at this flaky test :)

[kkewwei]

@kkewwei Thank you for taking a look at this flaky test :)

@cwperks, please have a look again.

[github-actions]

❌ Gradle check result for bf95318: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❕ Gradle check result for bf95318: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.35%. Comparing base (43e589a) to head (bf95318).
Report is 4 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #17397      +/-   ##
============================================
- Coverage     72.37%   72.35%   -0.02%     
+ Complexity    65519    65496      -23     
============================================
  Files          5291     5291              
  Lines        304302   304325      +23     
  Branches      44174    44181       +7     
============================================
- Hits         220240   220200      -40     
- Misses        65997    66018      +21     
- Partials      18065    18107      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[andrross]

Thanks @kkewwei!