[Pull-based ingestion] Support updates and deletes in ingestion flow#17822
[Pull-based ingestion] Support updates and deletes in ingestion flow#17822andrross merged 2 commits intoopensearch-project:mainfrom
Conversation
|
❌ Gradle check result for 89bfb56: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
varunbharadwaj
force-pushed
the
vb/updates
branch
2 times, most recently
from
97e2cc6 to
37197bc
Compare
varunbharadwaj
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
bugmakerrrrrr,
cwperks,
dbwiddis,
gbbafna,
jainankitk,
jed326,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
|
❌ Gradle check result for 37197bc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for 54cae36: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17822 +/- ##
============================================
- Coverage 72.47% 72.35% -0.12%
+ Complexity 66534 66459 -75
============================================
Files 5408 5410 +2
Lines 308217 308262 +45
Branches 44749 44756 +7
============================================
- Hits 223369 223051 -318
- Misses 66591 66884 +293
- Partials 18257 18327 +70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrross
left a comment
andrross
left a comment
There was a problem hiding this comment.
@varunbharadwaj Can you rebase and fix conflicts?
Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com>
Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com>
varunbharadwaj
force-pushed
the
vb/updates
branch
from
54cae36 to
9a15c44
Compare
|
❌ Gradle check result for 9a15c44: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…pensearch-project#17822) * Support updates and deletes in ingestion flow Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com> * Move ID generation to common util Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com> --------- Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com> Signed-off-by: Sriram Ganesh <srignsh22@gmail.com>
…pensearch-project#17822) * Support updates and deletes in ingestion flow Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com> * Move ID generation to common util Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com> --------- Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
…pensearch-project#17822) * Support updates and deletes in ingestion flow Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com> * Move ID generation to common util Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com> --------- Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
3 participants
Description
This PR adds support in the ingestion flow to support updates and deletes. Additionally, an ID will be auto-generated for upserts if not present in the incoming message.
Related Issues
Builds on top of #16929
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.