Skip to content

[Pull-based Ingestion] Support transient failure retries and create mode#18250

Merged
andrross merged 2 commits intoopensearch-project:mainfrom
varunbharadwaj:vb/createmode
May 12, 2025
Merged

[Pull-based Ingestion] Support transient failure retries and create mode#18250
andrross merged 2 commits intoopensearch-project:mainfrom
varunbharadwaj:vb/createmode

Conversation

@varunbharadwaj
Copy link
Copy Markdown
Contributor

@varunbharadwaj varunbharadwaj commented May 9, 2025

Description

  1. Support upto 2 retries to handle transient failures before dropping a message, when using drop error policy.
  2. Support create mode along with currently supported index and delete. This will allow users to set document ID maintained by them while also improving performance by inserting the document in create/append mode.

Related Issues

Builds on top of #17427 and #17822

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 9, 2025

❌ Gradle check result for 46a2662: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 9, 2025

❌ Gradle check result for 627b12a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for 627b12a: SUCCESS

@codecov
Copy link
Copy Markdown

codecov bot commented May 10, 2025

Codecov Report

Attention: Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.

Project coverage is 72.54%. Comparing base (e40b47d) to head (a9856a8).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ndices/pollingingest/MessageProcessorRunnable.java 80.00% 2 Missing and 4 partials ⚠️
...a/org/opensearch/index/engine/IngestionEngine.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18250      +/-   ##
============================================
- Coverage     72.56%   72.54%   -0.02%     
+ Complexity    67380    67345      -35     
============================================
  Files          5488     5488              
  Lines        310994   311005      +11     
  Branches      45212    45213       +1     
============================================
- Hits         225665   225634      -31     
- Misses        66906    67011     +105     
+ Partials      18423    18360      -63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

✅ Gradle check result for 005b4a7: SUCCESS

Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

❌ Gradle check result for a9856a8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Copy Markdown
Contributor

@yupeng9 yupeng9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

❕ Gradle check result for a9856a8: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@andrross andrross merged commit 5904352 into opensearch-project:main May 12, 2025
56 of 58 checks passed
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
…ode (opensearch-project#18250)

Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
…ode (opensearch-project#18250)

Signed-off-by: Varun Bharadwaj <varunbharadwaj1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants