Fix race condition in SearchOnlyReplicaIT#18072
Merged
andrross merged 1 commit intoopensearch-project:mainfrom Apr 24, 2025
Merged
Fix race condition in SearchOnlyReplicaIT#18072andrross merged 1 commit intoopensearch-project:mainfrom
andrross merged 1 commit intoopensearch-project:mainfrom
Conversation
I observed a failure in local testing due to this issue. The code previously was assuming it would observe a yellow cluster after restarting a node, but the node could restart and re-join the cluster before the assertion causing a failure. The `onNodeStopped` callback lets the test execute code before the node is restarted, so it should fix this issue. Signed-off-by: Andrew Ross <andrross@amazon.com>
andrross
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
ashking94,
bugmakerrrrrr,
cwperks,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Contributor
|
Nice, thanks for fixing @andrross |
Contributor
|
❕ Gradle check result for ee064ed: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18072 +/- ##
============================================
+ Coverage 72.47% 72.53% +0.05%
- Complexity 67034 67162 +128
============================================
Files 5478 5473 -5
Lines 310132 310088 -44
Branches 45087 45058 -29
============================================
+ Hits 224775 224923 +148
+ Misses 66960 66844 -116
+ Partials 18397 18321 -76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vinaykpud
approved these changes
Apr 24, 2025
kotwanikunal
approved these changes
Apr 24, 2025
This was referenced Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I observed a failure in local testing due to this issue. The code previously was assuming it would observe a yellow cluster after restarting a node, but the node could restart and re-join the cluster before the assertion causing a failure. The
onNodeStoppedcallback lets the test execute code before the node is restarted, so it should fix this issue.FYI @mch2 @vinaykpud
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.