Skip to content

Fix race condition in SearchOnlyReplicaIT #18072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrross merged 1 commit into from
Apr 24, 2025
Merged

Fix race condition in SearchOnlyReplicaIT #18072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions server/src/internalClusterTest/java/org/opensearch/indices/settings/SearchOnlyReplicaIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,10 +152,15 @@ public void testFailoverWithSearchReplicaWhenSearchNodeRestarts() throws Excepti
String searchNode = internalCluster().startSearchOnlyNode();
ensureGreen(TEST_INDEX);
// Restart Search Node
internalCluster().restartNode(searchNode);
// Ensure search shard is unassigned
ensureYellowAndNoInitializingShards(TEST_INDEX);
assertActiveSearchShards(0);
internalCluster().restartNode(searchNode, new InternalTestCluster.RestartCallback() {
@Override
public Settings onNodeStopped(String nodeName) throws Exception {
// Ensure search shard is unassigned
ensureYellowAndNoInitializingShards(TEST_INDEX);
assertActiveSearchShards(0);
return super.onNodeStopped(nodeName);
}
});
// Ensure search shard is recovered
ensureGreen(TEST_INDEX);
assertActiveSearchShards(1);
Expand Down
Loading