Change single shard assignment log message from warn to debug#18186
Merged
andrross merged 2 commits intoopensearch-project:2.19from May 5, 2025
Merged
Change single shard assignment log message from warn to debug#18186andrross merged 2 commits intoopensearch-project:2.19from
andrross merged 2 commits intoopensearch-project:2.19from
Conversation
This was referenced May 2, 2025
Contributor
|
❌ Gradle check result for d87fb58: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.19 #18186 +/- ##
============================================
+ Coverage 71.88% 71.91% +0.02%
- Complexity 65897 65938 +41
============================================
Files 5341 5341
Lines 307181 307181
Branches 44832 44832
============================================
+ Hits 220822 220896 +74
+ Misses 67932 67835 -97
- Partials 18427 18450 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
peternied
reviewed
May 2, 2025
Member
peternied
left a comment
peternied
left a comment
There was a problem hiding this comment.
@lukas-vlcek Thanks for making this change, lets tweak the changelog message before we merge.
andrross
reviewed
May 2, 2025
Contributor
lukas-vlcek
changed the title
This logging message is relevant to experimental feature that is not yet turned on by default. When this code runs in production then this logging message is confisung OPS because there is nothing they can do to address this WARN level message. Closes: opensearch-project#18137 Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
Co-authored-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
Contributor
andrross
approved these changes
May 5, 2025
github-project-automation
bot
moved this to 👀 In review
in Cluster Manager Project Board
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Cluster Manager Project Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This logging message is relevant to experimental feature that is not yet turned on by default. When this code runs in production then this logging message is confusing OPS because there is nothing they can do to address this WARN level message.
Related Issues
Resolves #18137
Check List
[ ] Functionality includes testing.[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.