Add more tests for JdkDownloadPlugin to capture existing behavior#19576
Merged
andrross merged 4 commits intoopensearch-project:mainfrom Oct 10, 2025
Merged
Conversation
Signed-off-by: Mikhail Stepura <mstepura@apple.com>
Contributor
Author
mishail
commented
Oct 9, 2025
buildSrc/src/test/java/org/opensearch/gradle/JdkDownloadPluginSetupRepositoryTests.java
Outdated
Show resolved
Hide resolved
Contributor
|
❌ Gradle check result for d76598a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Mikhail Stepura <mstepura@apple.com>
Contributor
|
❌ Gradle check result for 4848937: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
reta
reviewed
Oct 9, 2025
buildSrc/src/main/java/org/opensearch/gradle/JdkDownloadPlugin.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Oct 9, 2025
buildSrc/src/main/java/org/opensearch/gradle/JdkDownloadPlugin.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mikhail Stepura <mstepura@apple.com>
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19576 +/- ##
============================================
+ Coverage 73.06% 73.12% +0.06%
- Complexity 70617 70664 +47
============================================
Files 5723 5723
Lines 323473 323473
Branches 46845 46845
============================================
+ Hits 236348 236547 +199
+ Misses 68074 67857 -217
- Partials 19051 19069 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrross
approved these changes
Oct 10, 2025
rgsriram
pushed a commit
to rgsriram/OpenSearch
that referenced
this pull request
Oct 11, 2025
…pensearch-project#19576) Signed-off-by: Mikhail Stepura <mstepura@apple.com>
peteralfonsi
pushed a commit
to peteralfonsi/OpenSearch
that referenced
this pull request
Oct 15, 2025
…pensearch-project#19576) Signed-off-by: Mikhail Stepura <mstepura@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We need to modify the
JdkDownloadPluginfor our needs and this PR is to capture existing behavior to avoid regressions after refactoring.Test coverage before:
and after this change:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.