rename API fields to snake_case

[05Har-sh]

Description

This PR updates several field names in the /{index}/_recovery API response from camelCase to snake_case to maintain consistency
I have verified these changes by running RecoverySourceTests locally and the build was successful

Related Issues

Fixes #16334

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Summary by CodeRabbit

• Updates
  • Standardized JSON output for recovery operations to use snake_case field names, improving consistency of API responses.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Updated JSON field names in SnapshotRecoverySource and RemoteStoreRecoverySource to use snake_case in XContent serialization for five properties: restoreUUID, isSearchableSnapshot, remoteStoreIndexShallowCopy, sourceRemoteStoreRepository, and sourceRemoteTranslogRepository.

Changes

Cohort / File(s)

Summary

Recovery Source JSON Serialization server/src/main/java/org/opensearch/cluster/routing/RecoverySource.java

Renamed five JSON output field names in XContent serialization from camelCase to snake_case: restoreUUID → restore_uuid, isSearchableSnapshot → is_searchable_snapshot, remoteStoreIndexShallowCopy → remote_store_index_shallow_copy, sourceRemoteStoreRepository → source_remote_store_repository, sourceRemoteTranslogRepository → source_remote_translog_repository. No read-path, internal field name, or write-path changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A hop, a skip, from camel to snake,

Fields now lean, no casing mistake,
Underscores hum where capitals played,
Recovery output tidy, neatly relayed.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the primary change: renaming API field names from camelCase to snake_case, which is the main objective of the PR.
Description check	✅ Passed	The description follows the template structure, provides a clear explanation of changes, references the related issue #16334, and completes the checklist with appropriate selections.
Linked Issues check	✅ Passed	The PR successfully addresses issue #16334 by converting camelCase field names (restoreUUID, isSearchableSnapshot, remoteStoreIndexShallowCopy, sourceRemoteStoreRepository, sourceRemoteTranslogRepository) to snake_case in the /{index}/_recovery API response.
Out of Scope Changes check	✅ Passed	All changes in the PR are directly scoped to renaming field names in RecoverySource.java for the /{index}/_recovery API response, with no extraneous modifications beyond the stated objectives.

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b04a647 and b047b22.

📒 Files selected for processing (1)

• server/src/main/java/org/opensearch/cluster/routing/RecoverySource.java

🚧 Files skipped from review as they are similar to previous changes (1)

• server/src/main/java/org/opensearch/cluster/routing/RecoverySource.java

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

❌ Gradle check result for b047b22: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[05Har-sh]

/check-pull-request

[rick2244]

Hi! I’m interested in working on this issue.
I plan to update the API response fields to snake_case and verify changes with RecoverySourceTests.
Please let me know if this is still available.

[opensearch-trigger-bot]

This PR is stalled because it has been open for 30 days with no activity.

[sandeshkr419]

The only problem with this change is backward compatibility, which will break.
We can revisit this change ahead of 4.0 release once as we avoid any breaking changes in minor releases.

[05Har-sh]

Thank you for the review! I understand the concern regarding backward compatibility. I'm happy to revisit this for the 4.0 release, Please let me know if there are any other adjustments needed in the meantime.