Skip to content

rename API fields to snake_case #20351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
05Har-sh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

rename API fields to snake_case #20351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions server/src/main/java/org/opensearch/cluster/routing/RecoverySource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,11 +414,11 @@ public void addAdditionalFields(XContentBuilder builder, ToXContent.Params param
.field("snapshot", snapshot.getSnapshotId().getName())
.field("version", version.toString())
.field("index", index.getName())
.field("restoreUUID", restoreUUID)
.field("isSearchableSnapshot", isSearchableSnapshot)
.field("remoteStoreIndexShallowCopy", remoteStoreIndexShallowCopy)
.field("sourceRemoteStoreRepository", sourceRemoteStoreRepository)
.field("sourceRemoteTranslogRepository", sourceRemoteTranslogRepository);
.field("restore_uuid", restoreUUID)
.field("is_searchable_snapshot", isSearchableSnapshot)
.field("remote_store_index_shallow_copy", remoteStoreIndexShallowCopy)
.field("source_remote_store_repository", sourceRemoteStoreRepository)
.field("source_remote_translog_repository", sourceRemoteTranslogRepository);
}
Copy link
Copy Markdown
Member

@sandeshkr419 sandeshkr419 Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only problem with this change is backward compatibility, which will break.
We can revisit this change ahead of 4.0 release once as we avoid any breaking changes in minor releases.

Copy link
Copy Markdown
Author

@05Har-sh 05Har-sh Feb 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review! I understand the concern regarding backward compatibility. I'm happy to revisit this for the 4.0 release, Please let me know if there are any other adjustments needed in the meantime.


@Override
Expand Down Expand Up @@ -522,7 +522,7 @@ public Type getType() {

@Override
public void addAdditionalFields(XContentBuilder builder, ToXContent.Params params) throws IOException {
builder.field("version", version.toString()).field("index", index.getName()).field("restoreUUID", restoreUUID);
builder.field("version", version.toString()).field("index", index.getName()).field("restore_uuid", restoreUUID);
}

@Override
Expand Down
Loading