Skip to content

Publish transport-netty4 module to Central Repository#4054

Merged
saratvemulapalli merged 1 commit intoopensearch-project:mainfrom
dbwiddis:publish-netty4
Aug 1, 2022
Merged

Publish transport-netty4 module to Central Repository#4054
saratvemulapalli merged 1 commit intoopensearch-project:mainfrom
dbwiddis:publish-netty4

Conversation

@dbwiddis
Copy link
Copy Markdown
Member

Signed-off-by: Daniel Widdis widdis@gmail.com

Description

The extension framework opensearch-sdk requires the transport-netty4 module as a dependency.

Issues Resolved

Fixes #3118

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Daniel Widdis <widdis@gmail.com>
@dbwiddis dbwiddis requested review from a team and reta as code owners July 31, 2022 01:37
@github-actions
Copy link
Copy Markdown
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 31, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.60%. Comparing base (740f75d) to head (c81bb49).
⚠️ Report is 4745 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4054      +/-   ##
============================================
+ Coverage     70.50%   70.60%   +0.09%     
- Complexity    56848    56924      +76     
============================================
  Files          4583     4583              
  Lines        273931   273931              
  Branches      40158    40158              
============================================
+ Hits         193146   193404     +258     
+ Misses        64561    64323     -238     
+ Partials      16224    16204      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

apply plugin: 'opensearch.internal-cluster-test'

// The transport-netty4 plugin is published to maven
apply plugin: 'opensearch.publish'
Copy link
Copy Markdown
Member

@dreamer-89 dreamer-89 Jul 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbwiddis : Thanks for this PR. I have few questions around this change for my own understanding.

  1. How is opensearch-sdk consuming this plugin ?
  2. Why do we want to have plugin in core but consumed in opensearch-sdk ?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is opensearch-sdk consuming this plugin ?

We are using the TransportService wrapping Netty4Transport as our means of having the extensions communicate with OpenSearch itself. See here for example.

Presently we have simply copied all the classes over into a package in the sdk during development. We'd like to move this to a dependency published to Maven.

Why do we want to have plugin in core but consumed in opensearch-sdk ?

It will also be consumed in core for remote communication with the extensions. That has not yet been added as we are temporarily using plugin features. See here for where the TransportService is used and will eventually also consume this dependency.

@owaiskazi19 please clarify/correct anything I may have misstated.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dbwiddis for the details.

@saratvemulapalli saratvemulapalli added v3.0.0 Issues and PRs related to version 3.0.0 v2.2.0 backport 2.x Backport to 2.x branch labels Aug 1, 2022
@saratvemulapalli saratvemulapalli merged commit 707ca13 into opensearch-project:main Aug 1, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 1, 2022
Signed-off-by: Daniel Widdis <widdis@gmail.com>
(cherry picked from commit 707ca13)
pranikum pushed a commit to pranikum/OpenSearch that referenced this pull request Aug 2, 2022
saratvemulapalli pushed a commit that referenced this pull request Aug 2, 2022
Signed-off-by: Daniel Widdis <widdis@gmail.com>
(cherry picked from commit 707ca13)

Co-authored-by: Daniel Widdis <widdis@gmail.com>
@dbwiddis dbwiddis deleted the publish-netty4 branch August 3, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x Backport to 2.x branch v2.2.0 v3.0.0 Issues and PRs related to version 3.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publish Netty module as a maven artifact

4 participants