Publish transport-netty4 module to Central Repository#4054
Publish transport-netty4 module to Central Repository#4054saratvemulapalli merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4054 +/- ##
============================================
+ Coverage 70.50% 70.60% +0.09%
- Complexity 56848 56924 +76
============================================
Files 4583 4583
Lines 273931 273931
Branches 40158 40158
============================================
+ Hits 193146 193404 +258
+ Misses 64561 64323 -238
+ Partials 16224 16204 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| apply plugin: 'opensearch.internal-cluster-test' | ||
|
|
||
| // The transport-netty4 plugin is published to maven | ||
| apply plugin: 'opensearch.publish' |
There was a problem hiding this comment.
@dbwiddis : Thanks for this PR. I have few questions around this change for my own understanding.
- How is opensearch-sdk consuming this plugin ?
- Why do we want to have plugin in core but consumed in opensearch-sdk ?
There was a problem hiding this comment.
How is opensearch-sdk consuming this plugin ?
We are using the TransportService wrapping Netty4Transport as our means of having the extensions communicate with OpenSearch itself. See here for example.
Presently we have simply copied all the classes over into a package in the sdk during development. We'd like to move this to a dependency published to Maven.
Why do we want to have plugin in core but consumed in opensearch-sdk ?
It will also be consumed in core for remote communication with the extensions. That has not yet been added as we are temporarily using plugin features. See here for where the TransportService is used and will eventually also consume this dependency.
@owaiskazi19 please clarify/correct anything I may have misstated.
Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit 707ca13)
…ject#4054) Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis widdis@gmail.com
Description
The extension framework opensearch-sdk requires the transport-netty4 module as a dependency.
Issues Resolved
Fixes #3118
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.