Removing Netty4 local copy and consume from Maven#76
Merged
saratvemulapalli merged 5 commits intoopensearch-project:mainfrom Aug 8, 2022
saratvemulapalli:remove-netty4-local-copy
Merged
Removing Netty4 local copy and consume from Maven#76saratvemulapalli merged 5 commits intoopensearch-project:mainfrom saratvemulapalli:remove-netty4-local-copy
saratvemulapalli merged 5 commits intoopensearch-project:mainfrom
saratvemulapalli:remove-netty4-local-copy
Conversation
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
dbwiddis
reviewed
Aug 3, 2022
Member
dbwiddis
left a comment
dbwiddis
left a comment
There was a problem hiding this comment.
You can remove the targetExclude("**/netty4/*") line from gradle/formatting.gradle (spotless license exclusion).
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
dbwiddis
previously approved these changes
Aug 4, 2022
Member
dbwiddis
left a comment
dbwiddis
left a comment
There was a problem hiding this comment.
And the javadoc exclusion which you also caught. LGTM!
owaiskazi19
reviewed
Aug 5, 2022
| @@ -44,6 +44,7 @@ configurations { | |||
|
|
|||
Member
There was a problem hiding this comment.
We can remove the commented code here: https://github.com/opensearch-project/opensearch-sdk/pull/76/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7R55-R63
Member
Author
There was a problem hiding this comment.
The link redirects to the same diff. Could you point me to the link on main?
Member
There was a problem hiding this comment.
Not sure why the link redirects to the same diff. May be since it's not a part of this PR but here it is https://github.com/opensearch-project/opensearch-sdk/blob/main/build.gradle#L55-L62
owaiskazi19
previously approved these changes
Aug 5, 2022
Member
owaiskazi19
left a comment
owaiskazi19
left a comment
There was a problem hiding this comment.
One small nit. Rest LGTM!
Thanks @saratvemulapalli for this change.
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
saratvemulapalli
dismissed stale reviews from owaiskazi19 and dbwiddis
via
67ff1b9
dbwiddis
approved these changes
Aug 8, 2022
ryanbogan
approved these changes
Aug 8, 2022
dbwiddis
added a commit
to dbwiddis/opensearch-sdk-java
that referenced
this pull request
Oct 17, 2022
Signed-off-by: Daniel Widdis <widdis@gmail.com>
joshpalis
pushed a commit
that referenced
this pull request
Oct 19, 2022
* Delete unnecessary netty licenses missed in #76 Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add copyright line to license header Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add copyright to headers via spotlessApply Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Daniel Widdis <widdis@gmail.com>
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
) * Removing Netty4 local copy and consume from Maven Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> * Removing from spotless exclusion Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> * Removing from JavaDocs Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> * Addressing comments Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
* Delete unnecessary netty licenses missed in opensearch-project#76 Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add copyright line to license header Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add copyright to headers via spotlessApply Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Daniel Widdis <widdis@gmail.com>
caokyhieu
pushed a commit
to caokyhieu/opensearch-sdk-java
that referenced
this pull request
Aug 15, 2025
) * Removing Netty4 local copy and consume from Maven Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> * Removing from spotless exclusion Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> * Removing from JavaDocs Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> * Addressing comments Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
caokyhieu
pushed a commit
to caokyhieu/opensearch-sdk-java
that referenced
this pull request
Aug 15, 2025
* Delete unnecessary netty licenses missed in opensearch-project#76 Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add copyright line to license header Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add copyright to headers via spotlessApply Signed-off-by: Daniel Widdis <widdis@gmail.com> Signed-off-by: Daniel Widdis <widdis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sarat Vemulapalli vemulapallisarat@gmail.com
Description
Removing local copy of Netty4 and consume from OpenSearch as Maven dependency.
Thanks to @dbwiddis's PR on OpenSearch: opensearch-project/OpenSearch#4054
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.