Conversation
…n directory 'test/framework' (#4051) To support inclusive language, the master terminology is going to be replaced by cluster manager in the code base. After the class MasterService has been deprecated and class ClusterManagerService has been created in #4022 / commit 740f75d, the classes in `test/framework` directory with name 'MasterService' can be deprecated and renamed. - Rename the following classes in `test/framework` directory: FakeThreadPoolMasterService -> FakeThreadPoolClusterManagerService BlockMasterServiceOnMaster -> BlockClusterManagerServiceOnClusterManager BusyMasterServiceDisruption -> BusyClusterManagerServiceDisruption In the following commit, I will add back the above 3 classes with the old name and deprecate them, to keep the backwards compatibility. Signed-off-by: Tianli Feng <ftianli@amazon.com> (cherry picked from commit bea5d1a)
opensearch-trigger-bot
bot
requested review from
a team and
reta
as code owners
tlfeng
added
enhancement
Contributor
Gradle Check (Jenkins) Run Completed with:
|
tlfeng
approved these changes
Aug 1, 2022
Codecov Report
@@ Coverage Diff @@
## 2.x #4057 +/- ##
============================================
+ Coverage 70.52% 70.55% +0.03%
- Complexity 56524 56557 +33
============================================
Files 4533 4533
Lines 272158 272158
Branches 40003 40003
============================================
+ Hits 191936 192033 +97
+ Misses 64101 63939 -162
- Partials 16121 16186 +65
Help us with your feedback. Take ten seconds to tell us how you rate us. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport bea5d1a from #4051
To support inclusive language, the master terminology is going to be replaced by cluster manager in the code base.
After the class
MasterServicehas been deprecated and classClusterManagerServicehas been created in #4022 / commit 740f75d, the classes intest/frameworkdirectory with name 'MasterService' can be deprecated and renamed.test/frameworkdirectory:In the following PR, I will add back the above 3 classes with the old name and deprecate them, to keep the backwards compatibility.