Skip to content

[Feature/extensions] Warn future developers not to pass headers to extensions#4430

Merged
peternied merged 4 commits into
opensearch-project:feature/extensionsfrom
peternied:header-warning
Sep 13, 2022
Merged

[Feature/extensions] Warn future developers not to pass headers to extensions#4430
peternied merged 4 commits into
opensearch-project:feature/extensionsfrom
peternied:header-warning

Conversation

@peternied
Copy link
Copy Markdown
Member

@peternied peternied commented Sep 6, 2022

Description

Warn future developers not to pass headers to extensions

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog) Note; I did not include any change log changes because I don't see a change log in this branch

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 6, 2022

Gradle Check (Jenkins) Run Completed with:

@owaiskazi19 owaiskazi19 changed the title Warn future developers not to pass headers to extensions [Feature/extensions] Warn future developers not to pass headers to extensions Sep 7, 2022
Copy link
Copy Markdown
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "here there be dragons" would be a more fun comment, but this one suffices.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 7, 2022

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 9, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 9, 2022

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 9, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.59%. Comparing base (14b899b) to head (039ad26).
⚠️ Report is 296 commits behind head on feature/extensions.

Additional details and impacted files
@@                   Coverage Diff                    @@
##             feature/extensions    #4430      +/-   ##
========================================================
- Coverage                 70.61%   70.59%   -0.03%     
+ Complexity                57436    57416      -20     
========================================================
  Files                      4641     4641              
  Lines                    276249   276249              
  Branches                  40384    40384              
========================================================
- Hits                     195083   195016      -67     
- Misses                    64847    64930      +83     
+ Partials                  16319    16303      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peternied
Copy link
Copy Markdown
Member Author

@opensearch-project/security What do you folks think, is this a worthwhile stopgap measure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants