[Feature/extensions] Warn future developers not to pass headers to extensions#4430
Merged
peternied merged 4 commits intoSep 13, 2022
Merged
Conversation
5 tasks
Contributor
Gradle Check (Jenkins) Run Completed with:
|
dbwiddis
reviewed
Sep 7, 2022
Member
dbwiddis
left a comment
There was a problem hiding this comment.
I think "here there be dragons" would be a more fun comment, but this one suffices.
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
1a8a26e to
039ad26
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/extensions #4430 +/- ##
========================================================
- Coverage 70.61% 70.59% -0.03%
+ Complexity 57436 57416 -20
========================================================
Files 4641 4641
Lines 276249 276249
Branches 40384 40384
========================================================
- Hits 195083 195016 -67
- Misses 64847 64930 +83
+ Partials 16319 16303 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@opensearch-project/security What do you folks think, is this a worthwhile stopgap measure? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Warn future developers not to pass headers to extensions
Issues Resolved
Check List
New functionality includes testing.All tests passNew functionality has been documented.New functionality has javadoc addedCommit changes are listed out in CHANGELOG.md file (See: Changelog)Note; I did not include any change log changes because I don't see a change log in this branchBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.