[Feature/extensions]Enforce type safety for NamedWriteableRegistryParseRequest#4923
Merged
owaiskazi19 merged 3 commits intoopensearch-project:feature/extensionsfrom Oct 26, 2022
Merged
Conversation
Signed-off-by: mloufra <mloufra@amazon.com>
Signed-off-by: mloufra <mloufra@amazon.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
dbwiddis
reviewed
Oct 25, 2022
Member
dbwiddis
left a comment
dbwiddis
left a comment
There was a problem hiding this comment.
LGTM, just one comment about placement of the warning suppression.
Good job with all these changes, it was a bit more complicated than I expected!
| * @param in StreamInput from which map entries of writeable names and their associated category classes are read from | ||
| * @throws IllegalArgumentException if the fully qualified class name is invalid and the class object cannot be generated at runtime | ||
| */ | ||
| @SuppressWarnings("unchecked") |
Member
There was a problem hiding this comment.
Generally we try to put @SuppressWarnings at the lowest scope possible. In the constructor we were assigning a value to an instance variable, so we had to use the method level, but here we are assigning to a local variable. You should be able to put this suppression down above line 47.
Contributor
Author
There was a problem hiding this comment.
got it, I will move @SuppressWarnings in next commit
Signed-off-by: mloufra <mloufra@amazon.com>
Contributor
Gradle Check (Jenkins) Run Completed with:
|
dbwiddis
approved these changes
Oct 25, 2022
owaiskazi19
approved these changes
Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mloufra mloufra@amazon.com
Description
Add generic type for
categoryClassinNamedWriteable RegistryParseRequest,NamedWriteableRegistryResponse,ExtensionNamedWriteableRegistry,NamedWriteableRegistryResponseHandlerandExtensionsOrchestratorTestsEquivalent PR on OpenSearch-sdk-java: opensearch-project/opensearch-sdk-java#203
Issues Resolved
opensearch-project/opensearch-sdk-java#130
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.