Enforce type safety for ExtensionNamedWriteableRegistry#203
Merged
owaiskazi19 merged 3 commits intoopensearch-project:mainfrom Oct 26, 2022
Merged
Enforce type safety for ExtensionNamedWriteableRegistry#203owaiskazi19 merged 3 commits intoopensearch-project:mainfrom
owaiskazi19 merged 3 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: mloufra <mloufra@amazon.com>
dbwiddis
reviewed
Oct 25, 2022
Member
dbwiddis
left a comment
dbwiddis
left a comment
There was a problem hiding this comment.
Looking good! One minor nit.
src/main/java/org/opensearch/sdk/ExtensionNamedWriteableRegistry.java
Outdated
Show resolved
Hide resolved
Signed-off-by: mloufra <mloufra@amazon.com>
dbwiddis
reviewed
Oct 25, 2022
src/main/java/org/opensearch/sdk/ExtensionNamedWriteableRegistry.java
Outdated
Show resolved
Hide resolved
dbwiddis
requested changes
Oct 25, 2022
Member
dbwiddis
left a comment
dbwiddis
left a comment
There was a problem hiding this comment.
You only need to suppress an unchecked cast when you actually cast. After updating to the maven local you didn't need to cast any more, so you don't need to suppress any more either!
Signed-off-by: mloufra <mloufra@amazon.com>
dbwiddis
approved these changes
Oct 26, 2022
owaiskazi19
approved these changes
Oct 26, 2022
kokibas
pushed a commit
to kokibas/opensearch-sdk-java
that referenced
this pull request
Mar 17, 2023
…roject#203) * add generic type Signed-off-by: mloufra <mloufra@amazon.com> * move @SuppressWarnings at lowest scope possible Signed-off-by: mloufra <mloufra@amazon.com> * remove @SuppressWarnings Signed-off-by: mloufra <mloufra@amazon.com> Signed-off-by: mloufra <mloufra@amazon.com>
caokyhieu
pushed a commit
to caokyhieu/opensearch-sdk-java
that referenced
this pull request
Aug 15, 2025
…roject#203) * add generic type Signed-off-by: mloufra <mloufra@amazon.com> * move @SuppressWarnings at lowest scope possible Signed-off-by: mloufra <mloufra@amazon.com> * remove @SuppressWarnings Signed-off-by: mloufra <mloufra@amazon.com> Signed-off-by: mloufra <mloufra@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mloufra mloufra@amazon.com
Description
Add generic type for
categoryClassinExtensionNamedWriteableRegistryandTestNamedWriteableRegistryAPIEquivalent PR on OpenSearch: opensearch-project/OpenSearch#4923
Issues Resolved
#130
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.