Compression Levels Settings for zstd and zstd_no_dict#8312
Merged
reta merged 5 commits intoopensearch-project:mainfrom Jul 7, 2023
Merged
Compression Levels Settings for zstd and zstd_no_dict#8312reta merged 5 commits intoopensearch-project:mainfrom
reta merged 5 commits intoopensearch-project:mainfrom
Conversation
6bdf3f5 to
648200d
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
648200d to
7a89c78
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8312 +/- ##
============================================
- Coverage 70.87% 70.86% -0.01%
- Complexity 56922 56946 +24
============================================
Files 4758 4758
Lines 269337 269225 -112
Branches 39409 39408 -1
============================================
- Hits 190886 190786 -100
+ Misses 62339 62326 -13
- Partials 16112 16113 +1
|
d76b56a to
1f184b1
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
1f184b1 to
cc53b72
Compare
mgodwan
reviewed
Jun 29, 2023
server/src/main/java/org/opensearch/index/codec/CodecService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/codec/customcodecs/Lucene95CustomCodec.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/opensearch/index/codec/CodecTests.java
Outdated
Show resolved
Hide resolved
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
Gradle Check (Jenkins) Run Completed with:
|
dblock
approved these changes
Jul 6, 2023
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
5a79539 to
fddebac
Compare
Contributor
Gradle Check (Jenkins) Run Completed with:
|
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8312-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ca7045e8471c7394e502744703628c8d8adec445
# Push it to GitHub
git push --set-upstream origin backport/backport-8312-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
Contributor
|
@sarthakaggarwal97 could you please make a manual backport to |
5 tasks
sarthakaggarwal97
added a commit
to sarthakaggarwal97/OpenSearch
that referenced
this pull request
Jul 9, 2023
…ject#8312) * Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * addressing review comments Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * refactoring codec service Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * index settings assertion Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit ca7045e)
6 tasks
sarthakaggarwal97
added a commit
to sarthakaggarwal97/OpenSearch
that referenced
this pull request
Jul 9, 2023
…ject#8312) * Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * addressing review comments Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * refactoring codec service Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * index settings assertion Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit ca7045e)
sarthakaggarwal97
added a commit
to sarthakaggarwal97/OpenSearch
that referenced
this pull request
Jul 10, 2023
…ject#8312) * Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * addressing review comments Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * refactoring codec service Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * index settings assertion Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit ca7045e)
reta
pushed a commit
that referenced
this pull request
Jul 10, 2023
…nd ZSTD Codecs (#8558) * Compression Levels Settings for zstd and zstd_no_dict (#8312) * Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * addressing review comments Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * refactoring codec service Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * index settings assertion Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit ca7045e) * refactoring CodecService for 2.x Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
sarthakaggarwal97
added a commit
to sarthakaggarwal97/OpenSearch
that referenced
this pull request
Jul 10, 2023
…ject#8312) * Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * addressing review comments Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * refactoring codec service Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * index settings assertion Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit ca7045e)
6 tasks
Merged
3 tasks
vikasvb90
referenced
this pull request
in raghuvanshraj/OpenSearch
Jul 12, 2023
* Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * addressing review comments Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * refactoring codec service Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * index settings assertion Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
dzane17
pushed a commit
to dzane17/OpenSearch
that referenced
this pull request
Jul 12, 2023
…ject#8312) * Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * addressing review comments Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * refactoring codec service Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * index settings assertion Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
buddharajusahil
pushed a commit
to buddharajusahil/OpenSearch
that referenced
this pull request
Jul 18, 2023
…ject#8312) * Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * addressing review comments Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * refactoring codec service Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * index settings assertion Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv
pushed a commit
to baba-devv/OpenSearch
that referenced
this pull request
Jul 29, 2023
…ject#8312) * Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * addressing review comments Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * refactoring codec service Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * index settings assertion Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…ject#8312) * Enabling compression levels as index settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * addressing review comments Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * refactoring codec service Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * index settings assertion Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> * default compression level change in the settings Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> --------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables the compression level settings for the
zstdandzstd_no_dictcodecs. The prerequisite for this PR is #7908Related Issues
Resolves #7555
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.